Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member management UI issues #11755

Closed
4 tasks done
JohnONolan opened this issue Apr 20, 2020 · 4 comments
Closed
4 tasks done

Member management UI issues #11755

JohnONolan opened this issue Apr 20, 2020 · 4 comments
Assignees
@kevinansfield @rishabhgrg
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@JohnONolan
Copy link
Member

JohnONolan commented Apr 20, 2020 •
edited
Loading

When navigating to the members screen in Ghost Admin, there are several UI issues which we need to get on top of:

  • Loading spinner in the wrong place, not vertically centered
  • Intermittently loads only 1 member for 5-10 seconds
  • When the rest are loaded, the screen scrolls all the way to the very bottom of the list
  • It is impossible to scroll up, again, with screen jumping around all over the place
@JohnONolan JohnONolan added bug [triage] something behaving unexpectedly affects:admin Anything relating to Ghost Admin labels Apr 20, 2020
@ErisDS ErisDS assigned kevinansfield and rishabhgrg and unassigned rishabhgrg Apr 20, 2020
rishabhgrg added a commit to TryGhost/Admin that referenced this issue Apr 21, 2020
@rishabhgrg
Fixed members loading spinner alignment
3f14c04 
refs TryGhost/Ghost#11755

Loading spinner on members screen was not vertically centered, this updates the spinner position.
kevinansfield added a commit to TryGhost/Admin that referenced this issue May 1, 2020
@kevinansfield
🐛 Improved scrolling of members screen in Firefox
3be0fcc 
refs TryGhost/Ghost#11755

- adjusted estimated height to match actual rendered size and enabled `staticHeight` to switch to a simpler algorithm inside vertical-collection
- prevents some jank seen when scrolling where rows jump
@kevinansfield
Copy link
Contributor

TryGhost/Admin@3be0fcc fixed the slightly janky scrolling I was seeing in Firefox 75 but I wasn't able to reproduce any of these in Firefox or other browsers:

  • Intermittently loads only 1 member for 5-10 seconds
  • When the rest are loaded, the screen scrolls all the way to the very bottom of the list
  • It is impossible to scroll up, again, with screen jumping around all over the place

@ErisDS ErisDS added the members label May 28, 2020
@ErisDS
Copy link
Member

ErisDS commented May 28, 2020

Worth checking if this is still reproducible once the new performant dashboard is in production.

@ErisDS
Copy link
Member

ErisDS commented Jun 12, 2020

These are now all definitely in production

@JohnONolan
Copy link
Member Author

Yesss this is fast and smooth now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

@rishabhgrg rishabhgrg

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevinansfield @ErisDS @JohnONolan @rishabhgrg