-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when applying complimentary plan to member #11765
Comments
There appear to be two causes for this so far:
|
This is in progress in this WIP PR: https://github.com/TryGhost/Members/pull/167/files Was a little slower than I'd have liked due to looking at the new "Prices" from Stripe and trying to use that, I think it's worth it though as this cleans up a lot of things! |
Closing in favour of https://github.com/TryGhost/Members/issues/168 |
Repro case from @kevinansfield:
Monthly/yearly plans set to zero-value isn't a valid use-case with the current plan implementation, so this can be fixed with additional validation on plan prices. |
https://stripe.com/docs/currencies#minimum-and-maximum-charge-amounts <-- resource for when we do validation |
The solution to this should be validating that the values are not < 1. This works for all currencies we support. There will be a larger refactor of currency support soon. |
refs TryGhost#11765 This ensures that plans will always be set to 1 of the currency
refs TryGhost/Ghost#11765 Adds handling to disallow plans of less than 1 Co-authored-by: Matt Hanley <3798302+matthanley@users.noreply.github.com>
refs #11765 This ensures that plans will always be set to 1 of the currency
The Ghost API & Admin no longer allow creating plans with an amount of 0. So future installs/setups should not run into this problems. We have not removed existing 0 amount plans, but they may still cause issues with Complimentary plans, the fix would be to update your plans to have an amount of 1 or more |
@allouis bump ! still occuring with |
@sbounmy If you think this is still a bug on the latest version, would you be able to open an issue with reproducible steps and stack traces from the errors and any other useful info? Thanks |
Originally reported at https://forum.ghost.org/t/complimentary-premium-plan-return-an-error/13738/1
(Internal discussion for future reference https://ghost.slack.com/archives/C02G9E68C/p1587559818050500)
The text was updated successfully, but these errors were encountered: