Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark cards in member emails do not render correctly in Outlook #12148

Closed
kevinansfield opened this issue Aug 20, 2020 · 0 comments
Closed

Bookmark cards in member emails do not render correctly in Outlook #12148

kevinansfield opened this issue Aug 20, 2020 · 0 comments
Assignees
@kevinansfield
Labels
bug [triage] something behaving unexpectedly P3 - Medium [triage] Bugs which we'll fix soon

Comments

@kevinansfield
Copy link
Contributor

Issue Summary

Bookmark cards when included in content sent to members do not render correctly in Outlook on Windows.

ol365-vertical-allowed-1366
@kevinansfield kevinansfield added bug [triage] something behaving unexpectedly members / mega P3 - Medium [triage] Bugs which we'll fix soon labels Aug 20, 2020
@kevinansfield kevinansfield self-assigned this Aug 20, 2020
kevinansfield added a commit to TryGhost/Koenig that referenced this issue Aug 22, 2020
@kevinansfield
🎨 Improved bookmark card rendering in Outlook
a9f43a4 
refs TryGhost/Ghost#12148

- added an Outlook-specific template that is added to the main template inside of conditional html comments so that the majority of email clients can keep the more modern responsive html
- added `juice` as a dependency so that we can inline styles and keep the Outlook-specific template simpler
  - we need to inline styles in advance because the Outlook-specific template appears as a html comment to non-Outlook parsers so it's not picked up when inlining styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
bug [triage] something behaving unexpectedly P3 - Medium [triage] Bugs which we'll fix soon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinansfield @ErisDS