Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl/Cmd+V not working for tags in post settings menu #12294

Closed
daniellockyer opened this issue Oct 20, 2020 · 4 comments · Fixed by TryGhost/Admin#1739
Closed

Ctrl/Cmd+V not working for tags in post settings menu #12294

daniellockyer opened this issue Oct 20, 2020 · 4 comments · Fixed by TryGhost/Admin#1739
Labels
bug [triage] something behaving unexpectedly stale [triage] Issues that were closed to to lack of traction

Comments

@daniellockyer
Copy link
Member

Issue Summary

Pasting in text, via Ctrl/Cmd+V, to the Tags field doesn't work in the post settings menu.

To Reproduce

  1. Have some text copied in your clipboard
  2. Open the post settings menu
  3. Click in the Tags field and try to paste via Ctrl/Cmd+V
  4. Note that nothing is entered.

Workaround is to use the mouse to right click and paste.

Technical details:

  • Ghost Version: 3.35.5
  • Node Version: 12.18.0
  • Browser/OS: Firefox/Linux
  • Database: MySQL
@kevinansfield
Copy link
Contributor

Note: This bug was possibly introduced as a side-effect of fixing the Cmd+S shortcut when token inputs have focus TryGhost/Admin#1707

@kevinansfield kevinansfield added customer bug [triage] something behaving unexpectedly labels Oct 20, 2020
@sainthkh
Copy link
Contributor

Confirmed that my PR caused the problem. I'm currently finding a solution.

sainthkh added a commit to sainthkh/Ghost-Admin that referenced this issue Oct 26, 2020
@sainthkh
Dispatch event to root only if the key combo is registered as shortcut
685a921 
Closes TryGhost/Ghost#12294.

Cache registered shortcuts and check KeyboardEvent before dispatching event to the root.
@sainthkh sainthkh mentioned this issue Oct 26, 2020
Merged
3 tasks
@stale
Copy link

stale bot commented Jan 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@matthanley matthanley added pinned [triage] Ignored by stalebot and removed pinned [triage] Ignored by stalebot labels Jan 25, 2021
@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale [triage] Issues that were closed to to lack of traction label Jun 9, 2021
@stale stale bot closed this as completed Jun 22, 2021
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Aug 3, 2022
@sainthkh
🐛 Fixed pasting into the post tags input not working (#1739)
35694e9 
closes TryGhost/Ghost#12294
refs #1707

- cache registered shortcuts and check KeyboardEvent before dispatching event to the root
tigefa4u pushed a commit to tigefa4u/Ghost that referenced this issue Aug 3, 2022
@sainthkh
🐛 Fixed pasting into the post tags input not working (TryGhost#1739)
3780e80 
closes TryGhost#12294
refs TryGhost/Admin#1707

- cache registered shortcuts and check KeyboardEvent before dispatching event to the root
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [triage] something behaving unexpectedly stale [triage] Issues that were closed to to lack of traction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dispatch event to root only if the key combo is registered as shortcut sainthkh/Ghost-Admin
4 participants
@kevinansfield @daniellockyer @matthanley @sainthkh