Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Customize" Email design button unresponsive #12459

Closed
stromfeldt opened this issue Dec 7, 2020 · 0 comments
Closed

"Customize" Email design button unresponsive #12459

stromfeldt opened this issue Dec 7, 2020 · 0 comments

Comments

@stromfeldt
Copy link
Contributor

stromfeldt commented Dec 7, 2020

Issue Summary

Nothing happens when clicking on the Customize button associated with the "Email design" feature (although the "Customize" text colour does change from grey to white on hover). The button used to work in a previous version, but as of version 3.39.0 (and possibly earlier) it no longer does anything. The issue persists across browsers. To make things confusing, I have another instance that is also on 3.39.0 where the button and functionality work just fine.

I'm sure there's many variables that could be at play, the only one popping into my head being that the version that works went from version 3.37.1 to 3.39.0, while the version that doesn't work went from 3.38.3 to 3.39.0 (and is now on 3.39.2).

Although I only happened to notice the issue on 3.39.0, two other users have mentioned on the forum that they're having the same issue, one having noticed it before 3.39.0

To Reproduce

  1. Click on the "Customize" button under "Email design". It may or may not work for you.

Firefox Web Console error log

Uncaught TypeError: e is null
default https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:12623
cleanHTML https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:11380
get https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1684
untrack https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3743
get https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1684
ne https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1649
didReceiveAttrs https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:11381
n https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:2370
trigger https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:2505
n https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:2370
create https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1236
https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3453
evaluate https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3348
evaluateSyscall https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3566
evaluateInner https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3560
evaluateOuter https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3560
next https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3638
execute https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3637
handleException https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3572
handleException https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3593
throw https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3568
evaluate https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3404
execute https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3568
rerender https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3594
render https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1464
_renderRoots https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1487
inTransaction https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3188
_renderRoots https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1486
_renderRootsTransaction https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1491
_revalidate https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1491
invoke https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3900
flush https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3892
flush https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3903
_end https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3954
end https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3916
_run https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3956
_join https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3955
join https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:3927
d https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:2799
handler https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:1340
setupHandler https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:2474
dispatch https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:704
handle https://mydomain.com/ghost/assets/vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:699
vendor.min-32f7369b224bb5d407d6214a1d020d3f.js:12623:82

Technical details:

  • Ghost Version: 3.39.2
  • Browser: Firefox 83.0, Chrome 87.0.4280.88
  • Database: mysql
rishabhgrg added a commit to rishabhgrg/Ghost-Admin that referenced this issue Dec 8, 2020
closes TryGhost/Ghost#12459

- Email design settings don't open in some cases when footer html is set as null, specifically on import
- Patches html cleanup to use empty string in case of null footer value
daniellockyer pushed a commit to TryGhost/Admin that referenced this issue Dec 8, 2020
closes TryGhost/Ghost#12459

- Email design settings don't open in some cases when footer html is set as null, specifically on import
- Patches html cleanup to use empty string in case of null footer value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant