Settings are not updated without server restart #165
Assignees
Milestone
Comments
ghost
assigned 
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this issue
Jun 17, 2013
- ghost.js - globals/globalConfig has become settings / settingsCache to make it clearer - app.js - the ghostGlobals local cache is gone, and the use of res.locals has been cleaned up and simplified, although this needs to be properly split into frontend and admin locals (to be finished in TryGhost#124) - frontend/index.js - doesn't need to be passed globals and nav properties as res.locals does this for us
ErisDS
added a commit
to ErisDS/Ghost
that referenced
this issue
Jun 17, 2013
- ghost.js - split the settings loading out of ghost.init, so that we have a function for loading / reloading settings - api.js - implemented a new requestHandler, the cachedSettingsRequestHandler which handles all aspects of local caching for settings when making requests - app.js - updated the settings api routes to use the new cached request handler
morficus
pushed a commit
to morficus/Ghost
that referenced
this issue
Sep 4, 2014
- ghost.js - globals/globalConfig has become settings / settingsCache to make it clearer - app.js - the ghostGlobals local cache is gone, and the use of res.locals has been cleaned up and simplified, although this needs to be properly split into frontend and admin locals (to be finished in TryGhost#124) - frontend/index.js - doesn't need to be passed globals and nav properties as res.locals does this for us
morficus
pushed a commit
to morficus/Ghost
that referenced
this issue
Sep 4, 2014
- ghost.js - split the settings loading out of ghost.init, so that we have a function for loading / reloading settings - api.js - implemented a new requestHandler, the cachedSettingsRequestHandler which handles all aspects of local caching for settings when making requests - app.js - updated the settings api routes to use the new cached request handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Settings, or rather the horrifically named ghostGlobals (sorry) are loaded on Ghost init. Which is kinda exactly what we want because we want settings to be cached rather than loaded on every request.
However, this caching is currently done in a rather adhoc store-some-stuff-on-the-ghost-instance (which also needs to die btw) kinda way, and therefore we don't update the settings if they change.
I think it's important to get this fixed, implement settings caching more explicitly, and remove the word ghostGlobals / globals from the code cos it makes everyone a little bit sick.
The text was updated successfully, but these errors were encountered: