Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discord/Slack Webhook Integration #20304

Closed
1 task done
fritz-fritz opened this issue Jun 3, 2024 · 2 comments · Fixed by #20328
Closed
1 task done

Discord/Slack Webhook Integration #20304

fritz-fritz opened this issue Jun 3, 2024 · 2 comments · Fixed by #20328
Labels
bug [triage] something behaving unexpectedly P4 - Low Product

Comments

@fritz-fritz
Copy link

Issue Summary

When using the native Slack integration with a Discord channel with no excerpt defined, the paywall feature is ignored in the snippet posted. This potentially leaks information that may be meant to keep from being public.

Additionally, the post's Author is not listed properly and is attributed to the blog itself.

image
image

Steps to Reproduce

  1. Write a post with a paywall but without an excerpt.
  2. Add the Slack integration to Discord by appending /slack to the end of the url and adding to Discord.
  3. Publish the post.

Ghost Version

5.82.8

Node.js Version

18.19.1

How did you install Ghost?

Digital Ocean droplet Ubuntu 24.04

Database type

SQLite3

Browser & OS version

No response

Relevant log / error output

No response

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Jun 3, 2024
@fritz-fritz
Copy link
Author

It seems to be taking the first 3 sentences of the post for the excerpt regardless if it is supposed to be behind a paywall based on my testing. Ideally it would stop if it hits a paywall.

@linear linear bot added P4 - Low bug [triage] something behaving unexpectedly Product and removed needs:triage [triage] this needs to be triaged by the Ghost team labels Jun 3, 2024
mike182uk added a commit to mike182uk/Ghost that referenced this issue Jun 5, 2024
@mike182uk
🐛 Fixed Slack webhook integration using member content in generated e…
0cb603f 
…xcerpt

refs [ONC-63](https://linear.app/tryghost/issue/ONC-63/discordslack-webhook-integration)
fixes [TryGhost#20304](TryGhost#20304)

When a post is published and sent to Slack via webhook, the excerpt generated
could contain member content. This change ensures that the excerpt does not
contain member content. This change also ensures that the author for the post
is correctly shown in Slack
mike182uk added a commit to mike182uk/Ghost that referenced this issue Jun 5, 2024
@mike182uk
🐛 Fixed Slack integration using member content in excerpt
de61591 
refs [ONC-63](https://linear.app/tryghost/issue/ONC-63/discordslack-webhook-integration)
fixes [TryGhost#20304](TryGhost#20304)

When a post is published and sent to Slack via webhook, the excerpt generated
could contain member content. This change ensures that the excerpt does not
contain member content. This change also ensures that the author for the post
is correctly shown in Slack
mike182uk added a commit to mike182uk/Ghost that referenced this issue Jun 5, 2024
@mike182uk
🐛 Fixed Slack integration using member content in excerpt
cce0d83 
- refs [ONC-63](https://linear.app/tryghost/issue/ONC-63/discordslack-webhook-integration)
- fixes [TryGhost#20304](TryGhost#20304)

When a post is published and sent to Slack via webhook, the excerpt generated
could contain member content. This change ensures that the excerpt does not
contain member content. This change also ensures that the author for the post
is correctly shown in Slack
mike182uk added a commit to mike182uk/Ghost that referenced this issue Jun 5, 2024
@mike182uk
🐛 Fixed Slack integration using member content in excerpt
e340d78 
- refs [ONC-63](https://linear.app/tryghost/issue/ONC-63/discordslack-webhook-integration)
- fixes [TryGhost#20304](TryGhost#20304)

When a post is published and sent to Slack via webhook, the excerpt generated
could contain member content. This change ensures that the excerpt does not
contain member content. This change also ensures that the author for the post
is correctly shown in Slack
@mike182uk mike182uk mentioned this issue Jun 5, 2024
Merged
mike182uk added a commit that referenced this issue Jun 5, 2024
@mike182uk
🐛 Fixed Slack integration using member content in excerpt (#20328)
0f283da 
- refs
[ONC-63](https://linear.app/tryghost/issue/ONC-63/discordslack-webhook-integration)
- fixes [#20304](#20304)

When a post is published and sent to Slack via webhook, the excerpt
generated could contain member content. This change ensures that the
excerpt does not contain member content. This change also ensures that
the author for the post is correctly shown in Slack
@mike182uk
Copy link
Member

Hey @fritz-fritz

This has been fixed in #20328 and should go out in the next release

Thanks for reporting 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [triage] something behaving unexpectedly P4 - Low Product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fixed Slack integration using member content in excerpt mike182uk/Ghost
2 participants
@mike182uk @fritz-fritz