Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy config flags #3241

Closed
ErisDS opened this issue Jul 11, 2014 · 8 comments · Fixed by #3874
Closed

Privacy config flags #3241

ErisDS opened this issue Jul 11, 2014 · 8 comments · Fixed by #3874
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Jul 11, 2014

From #3064

While we already have a flag to disable Ghost update-checks, I would suggest that a nice followup to this would be if there was a config flag for every item in PRIVACY.md to allow it to be disabled, if so desired. Along with a blanket rule flag, to disable absolutely everything. (Perhaps tinfoil: true)

To achieve this there needs to be config options for:

  • Google Fonts: googleFonts: false
  • Gravatar: gravatar: false
  • RPC Pings: rpcPing: false

We already have updateCheck: false

@ErisDS ErisDS added this to the 0.5.x Feature Release milestone Jul 11, 2014
@sebgie
Copy link
Contributor

sebgie commented Jul 11, 2014

Just a thought, to keep our config clean and structured I was wondering if we could introduce the new options as one setting?

Disable everything:
tinfoil: true

Disable specific options

tinfoil: {
    googleFonts: false,
    gravatar: false,
    rpcPing: false,
    updateCheck: false
}

updateCheck is probably already in use and therefore we would have to deprecate the option and remove it in a future version.

@morficus
Copy link
Contributor

If no one is working on this one, I call dibs ✋

@morficus
Copy link
Contributor

This is mostly ready, just having an issue on trying to exclude Google Fonts - WIP code here: morficus@0b59e81

If anyone has some time, I could use some help creating some type of template helper working that will still execute when inside conditional blocks like {{#if}} and {{#unless}}

@ErisDS
Copy link
Member Author

ErisDS commented Aug 22, 2014

What's not working with the {{#unless}} helper you're using?

@morficus
Copy link
Contributor

The helper doesn't get called at all with the {{#unless}} (you can put a
console.log out breakpoint to try).

But if I only do {{skip_google_fonts}} then the helper is executed.


Maurice W.

Sent from a mobile device. Please forgive any typos.
On Aug 22, 2014 2:27 AM, "Hannah Wolfe" notifications@github.com wrote:

What's not working with the {{#unless}} helper you're using?


Reply to this email directly or view it on GitHub
#3241 (comment).

@jaswilli
Copy link
Contributor

@morficus

Handlebars won't execute a function as an argument. {{#unless skip_google_fonts}} doesn't invoke skip_google_fonts and pass the result as an argument, it just checks to see if it is defined in the current context.

@ErisDS
Copy link
Member Author

ErisDS commented Aug 22, 2014

This is how I did a similar thing: bb490e4

Might not be the right way, but it worked

@morficus
Copy link
Contributor

@ErisDS thanks for the hint 👍
My Saturday I totally booked (all day volunteer event), so I'll take a stab at the final bit on Sunday (or late Saturday if I have any energy left)

morficus added a commit to morficus/Ghost that referenced this issue Sep 13, 2014
closes TryGhost#3241
- in config.js, the `privacy` attribute holds all privacy-related flags
- `privacy.userTinfoil: true` disables everything (equivalent to setting all flags to false)
- added helper function to core/server/config/index.js to checking privacy flags
- added helper function to core/server/config/index.js to show warning about deprecated items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants