Post-GUI-Update Changes

[JohnONolan]

As a part of the new GUI update - we are introducing many brand new (shiny!) bugs! This issue is intended to cover the things that need some additional TLC

• Ember body classes - Ember route based bodyclasses #3792 - This should make the mobile nav menu on the /ghost/settings work
• New Ember love to handle transitioning between settings views on mobile
• New Ember love on new mobile menu, @PaulAdamDavis did a first implementation of this here, which needs porting in: https://github.com/TryGhost/Ghost-UI/blob/GUI-2.0/docs/js/nav.js
• CSS bug, fix vertical centering on 404 page
• CSS bug, User profile settings needs to be unfucked <= @JohnONolan to provide mockup for how
• The markdown tab is borked - Markdown tab not working #3813
• Fix the Edit User UI cog icon / menu and back button Edit User UI #3925
• Regression: Lost settings nav icons
• Ember redux on the "back" button switching between mobile views on /ghost/content Mobile view transitions for content screen #4031
• Remove animated page transitions from mobile settings

Let's keep all New-GUI related bugs in the list above. Discussion below. Check em off as you go.

Fucking poetry.

[felixrieseberg]

I'm gonna go ahead and try to convince the 404 page to center the error vertically. Also, the new GUI is pretty sweet.

[felixrieseberg]

CSS bug, fix vertical centering on 404 page: fixed with #3812.

[novaugust]

re: ember love for mobile transitions on settings views, #3259 will be a good reference to the code that use to do this

[ErisDS]

A new thing I just spotted: signin screen on mobile on master currently looks like this (update fixed via ghost-ui):

[felixrieseberg]

@ErisDS I actually can't reproduce that (iOS 7.1.2, Mobile Safari & Chrome). More direct pointers to how you got it to be borked?

[ErisDS]

@felixrieseberg sorry, the convo continued on IRC, turned out it was fixed in ghost-ui and hadn't been published.

[ErisDS]

On the users screen, the settings menu which provides the delete user and transfer ownership options is missing.

[felixrieseberg]

I worked on that menu before, I'm sure I can bring it back.

[ErisDS]

@felixrieseberg there needs to be a design for it I think?

[felixrieseberg]

Well, let's wait for that then ;-) (I assumed we'd stick with the cog, but there are surely better ways, given that the menu currently has at most two options).

[novaugust]

"New Ember love to handle transitioning between settings views on mobile" is taken care of with #3862

update merged -- @JohnONolan you can check off the second box up there

[JohnONolan]

Added to task list, Regression: Lost settings nav icons

[ErisDS]

I believe this list is now complete and the issue can be closed.