Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Settings Menu Autosave #4517

Closed
ErisDS opened this issue Nov 24, 2014 · 1 comment · Fixed by #4564
Closed

Tag Settings Menu Autosave #4517

ErisDS opened this issue Nov 24, 2014 · 1 comment · Fixed by #4564
Labels
affects:admin Anything relating to Ghost Admin
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Nov 24, 2014

Note that there was some work done towards this in PR #4500.


All of the fields in the tag settings menu (TSM) should autosave themselves, in the same way as this works on the post settings menu.

When editing or creating a tag, save should be triggered on focus out from the text inputs - but the model should only be saved if the value is not blank, and has changed from it's previous value.

Saving should cause nprogress to fire.

The auto-saving behaviour should still allow the values to get reset when moving between the TSM for different tags, or a new tag.

The save button can be removed.

@ErisDS ErisDS added the affects:admin Anything relating to Ghost Admin label Nov 24, 2014
@ErisDS ErisDS added this to the Next Backlog milestone Nov 24, 2014
@novaugust novaugust mentioned this issue Nov 24, 2014
20 tasks
@naz
Copy link
Member

naz commented Dec 1, 2014

At the moment the tag is prevented from being saved whenever Tag Name is not provided. This creates a bit misleading experience, as someone could skip the tag name field and fill out the slug/description fields, which populates general tags list with a new entry. But whenever the page is refreshed all entries without name are lost. Maybe we should provide some kind of warning that name field is required, or maybe fill it out automatically ?

naz added a commit to naz/Ghost that referenced this issue Dec 3, 2014
closes TryGhost#4517

- adds autosave to name/slug/description fields in TMS
- adds nprogress indicator when saving
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants