Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation menu drag & drop #4540

Closed
ErisDS opened this issue Nov 28, 2014 · 7 comments · Fixed by #4858
Closed

Navigation menu drag & drop #4540

ErisDS opened this issue Nov 28, 2014 · 7 comments · Fixed by #4858
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Milestone

Comments

@ErisDS
Copy link
Member

ErisDS commented Nov 28, 2014

This is part of the Navigation epic: #4535, and requires #4537 & #4539


image

Clicking on the drag handles should allow the user to use drag and drop to reorder the items in the list. The items shouldn't lose any data, and the trash icons should work correctly after dragging.

The reordering doesn't need to save until the save button is pressed.

Notes on the interface:

  • Cursor state for drag handles should be "move" - there should be no other hover state for drag handles.
  • There should be no special highlight or state when a nav-item is being dragged
  • Grab handles and trash icons should have padding around them for increased hit area
@ErisDS ErisDS added settings good first issue [triage] Start here if you've never contributed before. affects:admin Anything relating to Ghost Admin labels Nov 28, 2014
@ErisDS ErisDS added this to the Next Backlog milestone Nov 28, 2014
@JohnONolan JohnONolan mentioned this issue Nov 28, 2014
5 tasks
@delgermurun
Copy link
Contributor

@ErisDS I think it is also requires #4539?

@ErisDS
Copy link
Member Author

ErisDS commented Dec 18, 2014

Good point, updated

@JoshKaufman
Copy link

I'm new here looking to get involved. is this ready to be worked on?

@PaulAdamDavis
Copy link
Member

Hi @JoshKaufman, and welcome!

This issue is blocked on me finishing #4694 :(
I hope to get it done in the next couple days though.

@PaulAdamDavis
Copy link
Member

Hello again @JoshKaufman, if you're still interested in getting involved, this issue is good to go now :)

@tidyui
Copy link

tidyui commented Jan 19, 2015

A simple question on this issue. What's the browser compability guidelines for the ghost admin and what is the prefered technology for implementing the drag-n-drop feature.

@PaulAdamDavis
Copy link
Member

We generally support the last 2 versions of major browsers, so IE10+ (the rest update automatically or new versions have a majority market share, so a non-issue). Can I Use says no mobile browser supports native drag & drop events, so they'll need a polyfill. I would imagine most polyfills aim to support as many browsers and devices as possible.

I think keeping it as close-to-the-metal as possible would be best, and likely the easiest to integrate with Ember? Native drag & drop (with a polyfill) makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin good first issue [triage] Start here if you've never contributed before.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants