New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Navigation #4535
Comments
@JohnONolan Two questions: Should the default 'Home' item only be present in the UI by default (and stored after pressing save) or should it be stored by default and output by the Should the navigation helper definitely always output absolute URLS? (Note: I moved that part of the spec to #4541) |
First question: the latter Second question: yes (imo) |
@JohnONolan - Accessibility is a must. Check out ARIA roles cheatsheet for help and a few links on that page. Hope this will help! |
#4539 is already closed, but this will be harder to change later. So here is my 2c: |
I got it now, the helper outputs a simple menu. Thanks @ErisDS. |
Hi there, just thought I'd share my view on post, pages & navigation structures from working with different content management systems for over ten years. A lot of other platforms make the visual distinction between navigation and the actual content like you're proposing here. One downside with it is that it cripples the publishing flow somewhat since most of the time you're first "writing content", and the "attching it" to a structure. In other words you're transforming a simple task into a two-step process. Also, for the person writing the content, the only point of separating the navigation structure from the pages is if it's possible to create several navigation structures and publish the same page in several of them at the same time. A simpler way to present this to the user would maybe be to create a new view called Pages/Site/Whatever where the navigation structure is shown. Here users can create "pages" of different kinds, for example:
When the user creates a new entry the new post is created together with the navigation item in a single transaction, making it seemless for the user and turning it into a single step. If this kind of view was created, then maybe it would also be logical to filter out posts with In other words, the same underlying structure could be used, it's just presented in a different way. Btw, I really love the project! Regards |
refs TryGhost#4535 - as discussed in the meeting on 1st February ;) - changed the fake-placeholder to only operate on the last item, this way it feels right, I think
refs TryGhost#4535 - all internal urls in ghost have a trailing slash, missing it out will cause nav-current to not work
Steps to ship it (:shipit:) -
|
ref TryGhost#4535 - don't need this any more :)
refs TryGhost#4535 - Rather than storing navigation data as a top level key, store it as @blog.navigation - Reference the global data from the helper
🚢 'd it 😁 |
The Navigation UI provides a simple user interface for creating a list of links to output in your theme. The interface allows for the clickable text and url for each link to be entered. Each item can be reordered using drag and drop, edited, removed and new items can be added to the end of the list. In the theme API, we get a new
{{navigation}}
helper, which works with a defaultnavigation.hbs
template, much the same as the{{pagination}}
helper.Sub Issues
Accessibility Questions
Should we wrap with
<nav role="navigation">
? IMO: Feels like clutter - I'd rather let the theme define the wrapping element.Should we put the ARIA role into the UL? Like
<ul class="nav" role="navigation">
to promote better accessibility standards by default? Is this a valid use of the role attribute?The text was updated successfully, but these errors were encountered: