Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Active menu state on settings navigation #4622

Closed
JohnONolan opened this issue Dec 10, 2014 · 1 comment · Fixed by #4623
Closed

Regression: Active menu state on settings navigation #4622

JohnONolan opened this issue Dec 10, 2014 · 1 comment · Fixed by #4623
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly p1:priority [triage] Priority for immediate patch release
Milestone
Current Backlog

Comments

@JohnONolan
Copy link
Member

image

Live in 0.5.6 - This should be white, not brown. Brown is the hover state. This is really, really ugly.

NB: afaik this is an Ember bug not a CSS bug. The CSS is correct when you load the page, but it fails when you change routes.
@JohnONolan JohnONolan added bug [triage] something behaving unexpectedly ghost-ui p1:priority [triage] Priority for immediate patch release labels Dec 10, 2014
@JohnONolan JohnONolan added this to the Current Backlog milestone Dec 10, 2014
@JohnONolan JohnONolan added the affects:admin Anything relating to Ghost Admin label Dec 10, 2014
@PaulAdamDavis
Copy link
Member

This is a :focus state. If you click elsewhere, the tab goes white.

I've spent ages ranting about this on Twitter, and the general consensus is: that's how browsers work now. 😒

vikhyat added a commit to vikhyat/Ghost that referenced this issue Dec 10, 2014
@vikhyat
Fix active menu state on settings navigation
297c33b 
closes TryGhost#4622
- unfocus ActivatingListItem link when clicked
@vikhyat vikhyat mentioned this issue Dec 10, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly p1:priority [triage] Priority for immediate patch release
Projects
None yet
Milestone
Current Backlog
Development

Successfully merging a pull request may close this issue.

Fix active menu state on settings navigation vikhyat/Ghost
2 participants
@JohnONolan @PaulAdamDavis