Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation - Saving with empty label deletes item rather than erroring #4942

Closed
novaugust opened this issue Feb 23, 2015 · 0 comments · Fixed by #4945
Closed

Navigation - Saving with empty label deletes item rather than erroring #4942

novaugust opened this issue Feb 23, 2015 · 0 comments · Fixed by #4945
Labels
bug [triage] something behaving unexpectedly
Milestone
Current Backlog

Comments

@novaugust
Copy link
Contributor

Steps to reproduce

  1. Delete the label for one of your nav items (leaving the url)
  2. Save

Expected behaviour

  1. An error message should pop up letting me know that I can't save with an empty label
@novaugust novaugust mentioned this issue Feb 23, 2015
Merged
@ErisDS ErisDS added the bug [triage] something behaving unexpectedly label Feb 23, 2015
@ErisDS ErisDS added this to the Current Backlog milestone Feb 23, 2015
novaugust added a commit to novaugust/Ghost that referenced this issue Feb 24, 2015
@novaugust
Don't save if nav items have empty labels
299fbf9 
Closes TryGhost#4942, Closes TryGhost#4944
- Also adds the `order` prop to the lastItem on save, so it doesn't jump about
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
Current Backlog
Development

Successfully merging a pull request may close this issue.

Don't save if nav items have empty labels novaugust/Ghost
2 participants
@ErisDS @novaugust