Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modals refactor #5798

Closed
2 of 4 tasks
kevinansfield opened this issue Sep 3, 2015 · 3 comments
Closed
2 of 4 tasks

Modals refactor #5798

kevinansfield opened this issue Sep 3, 2015 · 3 comments
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin
Milestone
Post-Zelda

Comments

@kevinansfield
Copy link
Contributor

During the Zelda release we ran into issues with modals and their interaction with validations and spin-buttons. One of the main problems is that hitting the confirm button will raise an action and then close the modal immediately, not taking into consideration async tasks or allowing the close to be halted.

  • Review of modal usage and desired behaviour
  • Switch to closure-actions and return promises from modal controller actions so that closing of modals can happen after async tasks and be dependent on success/failure
  • Fix auth regressions after ESA 1.0 upgrade #6061 re-instated the re-authentication modal but I realised there's an issue with it not saving the post after re-authenticating. It would be good to add that feature if the improved control structure allows it.
  • Modals should switch the keymaster scope to disable globals shortcuts and provide a way to register their own shortcuts (currently always switches to 'modal' scope - can we offer a way to customise?)
@kevinansfield kevinansfield added the affects:admin Anything relating to Ghost Admin label Sep 3, 2015
@kevinansfield kevinansfield self-assigned this Sep 3, 2015
@kevinansfield kevinansfield added this to the Post-Zelda milestone Sep 3, 2015
@ErisDS ErisDS mentioned this issue Oct 9, 2015
Closed
2 tasks
@ErisDS
Copy link
Member

ErisDS commented Oct 9, 2015

Note: once the refactor is complete it should be possible to revisit #5650

@ErisDS ErisDS closed this as completed Oct 9, 2015
@ErisDS ErisDS reopened this Oct 9, 2015
@ErisDS ErisDS mentioned this issue Nov 10, 2015
Closed
7 tasks
This was referenced Nov 12, 2015
Closed
Merged
kevinansfield added a commit to kevinansfield/Ghost that referenced this issue Jan 12, 2016
@kevinansfield
Refactor modals
1c6b208 
refs TryGhost#5798, closes TryGhost#5018
- adds new `gh-fullscreen-modal` component - modals are now specified in-context so that they can have deeper interaction with their surrounding components/controller/route, i.e. a modal component can be a thin confirm/deny wrapper over the underlying controller action keeping all context-sensitive logic in one place
- adds spin-buttons to all modals with async behaviour
- adds/improves behaviour of inline-validation in modals
- improves re-authenticate modal to properly handle validation and authentication errors
@acburdine
Copy link
Member

Did this get fixed by #6088?

@ErisDS
Copy link
Member

ErisDS commented Sep 19, 2016

Closing for now - if there's any work left to do maybe open a fresh issue?

@ErisDS ErisDS closed this as completed Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Milestone
Post-Zelda
Development

No branches or pull requests
3 participants
@kevinansfield @ErisDS @acburdine