Regression: No re-auth modal when saving editor with invalid session

[kevinansfield]

Steps to reproduce:

1. Create/edit a post and ensure it's saved
2. In web inspector find your ghost:sessionin the Local Storage section under the Resources tab and edit your access_token string
3. Change the post body and click save

Expected result: You are shown the re-authenticate modal from which you're are able to sign-in and continue

Actual result: You are shown an error alert: "Saving failed. The server returned an error (Server was not available)."

[kevinansfield]

I have a failing test in place for this. It appears that ember-simple-auth no longer raises the authorizationFailed action so we need to find the correct way to hook into this state with ESA 1.0.

[kevinansfield]

I think the solution to this is going to be further reaching than I first thought. The core problem is this:

• In ValidationEngine we override .save to handle validation (which is fine) but we also capture any errors raised and use getRequestErrorMessage (from utils/ajax.js) to replace the original error object with a string.
• Anywhere we use the .save().catch() pattern to do custom error handling we now either have an array of validation errors or a plain string - we've lost the ability to react according to the type of error we receive at the very edge of our application code
• .save().catch() has become a common pattern where we typically ignore the validation errors (they get handled by our inline validation) and then fire off an alert with the string returned from getRequestErrorMessage, and finally return nothing - we've now lost the ability to use Ember's error action in routes. The error action is useful as it starts at the furthest edge route and bubbles up to the application route, allowing a spectrum of fine-grained to high-level responses to an error.

Taking into consideration we eventually want to refactor ValidationEngine and update our API to return DS.Errors compatible error responses and possibly i18n keys I plan implement something like the following:

1. Remove the .catch In ValidationEngine.save(), this would result in the following behaviour:
   • reject with undefined if we have validation errors (current behaviour)
   • reject with with the original error object if we hit a server/other error (new behaviour)
2. Review everywhere we use the .save().catch() pattern to ensure that we are only handling the exceptional cases we care about, always return/throw the original error in a way that Ember will pick up
3. Use the error actions on leaf-routes where appropriate, eg. In the editor to show the re-auth modal
4. Add an error action to the application route that uses getRequestErrorMessage to show a suitable alert
5. Move logic from notifications.showAPIError into getRequestErrorMessage - this leaves the notifications service dealing purely with handling basic alerts/notifications