Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-search-input throws ember-wormhole error #7073

Closed
kevinansfield opened this issue Jul 5, 2016 · 0 comments · Fixed by TryGhost/Admin#108
Closed

gh-search-input throws ember-wormhole error #7073

kevinansfield opened this issue Jul 5, 2016 · 0 comments · Fixed by TryGhost/Admin#108
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly help wanted [triage] Ideal issues for contributors to help with

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Jul 5, 2016

At some point between 0.8 and master the gh-search-input component has started throwing this error when the dropdown is shown:

Error: The head node of a wormhole must be attached to the DOM

Reproduction steps:

  1. Click in the search box
  2. Start typing
  3. The error will be visible in the console although the dropdown is still shown.

This failing test can be added to core/client/tests/integration/components/gh-search-input.js as the same error is apparent in the tests as well as the application:

it('opens the dropdown on text entry', function () {
    this.render(hbs`{{gh-search-input}}`);
    // enter text to trigger search
    run(() => {
        this.$('input[type="search"]').val('test').trigger('input');
    });
});
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin help wanted [triage] Ideal issues for contributors to help with labels Jul 5, 2016
@kevinansfield kevinansfield changed the title Unable to integration test gh-search-input due to ember-wormhole error gh-search-input throws ember-wormhole error Jul 5, 2016
@kevinansfield kevinansfield added the bug [triage] something behaving unexpectedly label Jul 5, 2016
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jul 5, 2016
closes TryGhost/Ghost#7073
- reverts `ember-wormhole` to 0.3.6
- adds working test that was broken under `ember-wormhole` 0.4.0
acburdine pushed a commit to TryGhost/Admin that referenced this issue Jul 5, 2016
closes TryGhost/Ghost#7073
- reverts `ember-wormhole` to 0.3.6
- adds working test that was broken under `ember-wormhole` 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly help wanted [triage] Ideal issues for contributors to help with
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant