-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct upgrade from 0.7.x -> 0.10 does not work #7297
Comments
will look into quickly |
as @ErisDS has guessed, sitemap generation requests the database before the migration has finished. will create a PR with a fix on sunday/monday. sorry for trouble! |
Just hit this exact problem when upgrading from 0.7.1 to 0.10. |
Just to reiterate, our official recommendation is always to upgrade through each minor version one at a time (so 0.7.1 -> 0.8 -> 0.9 -> 0.10) |
closes TryGhost#7297 - move sitemap initialisation into sitemap handler - initialise sitemap on first request to sitemap
…7320) * 🐛 fix direct update closes TryGhost#7297 - move sitemap initialisation into sitemap handler - initialise sitemap on first request to sitemap * 🐛 fix how we pass options to migration files refs TryGhost#7317 - clone options when passing them into the migration/fixture files - do not use default sequence, because it does not clone the arguments
…7320) * 🐛 fix direct update closes TryGhost#7297 - move sitemap initialisation into sitemap handler - initialise sitemap on first request to sitemap * 🐛 fix how we pass options to migration files refs TryGhost#7317 - clone options when passing them into the migration/fixture files - do not use default sequence, because it does not clone the arguments
In the past, we have been pretty good at supporting upgrades from any version to any version. However, we do state in the docs that minor updates should be done one-at-a-time (see here).
Currently, when upgrading from 0.7.x -> 0.10 you'll see the following errors:
I believe that this is caused by the sitemap trying to generate when Ghost boots into maintenance mode whilst the migrations run. This is an oversight, as the API calls should fail (but don't because they are internal rather than HTTP which triggers the middleware). The updates to the sitemap to use
visibility
in 0.10 are the reason why this is suddenly causing a problem and wasn't before. The sitemap should not initialise until after maintenance mode is finished.I am not sure that this is a bug that warrants fixing. The workaround is to properly upgrade through the minor versions, from 0.7.x to 0.8 and then 0.9 and 0.10. This is a pain, but we are already working on alternative upgrade strategies for the future. For now, this is probably worth a short investigation to see if there is a quick fix.
The text was updated successfully, but these errors were encountered: