Multiple upgrade alerts + transparent alert background #7305
Labels
bug
[triage] something behaving unexpectedly
Comments
|
@JohnONolan should the upgrade alerts use the standard blue info alert or do you want to keep them white? |
|
Standard info blue is probably most appropriate right meow. I'd like to do a full review of alerts to make them less ugly for 1.0 though :) |
kevinansfield
added a commit
to kevinansfield/Ghost-Admin
that referenced
this issue
Sep 1, 2016
closes TryGhost/Ghost#7305 The `location` property of server-side notifications was being ignored by the client and so wasn't being used to de-duplicate alerts. - adds `key` attribute to `Notification` model - adds a serializer for notifications that renames the `location` key sent by the server to `key` - set the default background color of alerts to white so that alerts with no `type` set do not inherit the background color (useful in Ghost Desktop which has a transparent background color set)
kirrg001
pushed a commit
that referenced
this issue
Sep 1, 2016
refs #7305 * 🎨 display upgrade alerts with the correct "info" style * 💄 update use of notifications status/type/location attrs to reflect current usage
acburdine
pushed a commit
to TryGhost/Admin
that referenced
this issue
Sep 1, 2016
closes TryGhost/Ghost#7305 The `location` property of server-side notifications was being ignored by the client and so wasn't being used to de-duplicate alerts. - adds `key` attribute to `Notification` model - adds a serializer for notifications that renames the `location` key sent by the server to `key` - set the default background color of alerts to white so that alerts with no `type` set do not inherit the background color (useful in Ghost Desktop which has a transparent background color set)
mixonic
pushed a commit
to mixonic/Ghost
that referenced
this issue
Oct 28, 2016
refs TryGhost#7305 * 🎨 display upgrade alerts with the correct "info" style * 💄 update use of notifications status/type/location attrs to reflect current usage
geekhuyang
pushed a commit
to geekhuyang/Ghost
that referenced
this issue
Nov 20, 2016
refs TryGhost#7305 * 🎨 display upgrade alerts with the correct "info" style * 💄 update use of notifications status/type/location attrs to reflect current usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue Summary
If a Ghost installation is more than one version behind then an upgrade alert is shown for every version rather than only one alert for the latest upgrade available.
There is also an issue with the alert's background being transparent that is evident when using Ghost Desktop.
### Steps to Reproduce 1. Start up an old version of Ghost (e.g. 0.8.0) 2. Sign in 3. See an alert for both 0.9.0 and 0.9.1 ### Technical details: - Ghost Version: 0.8.0 ### Tasks: - [x] respect the `location` property of server-side upgrade notifications so that the client will automatically remove any duplicates (https://github.com/TryGhost/Admin/pull/242) - [x] add an explicit background colour to the upgrade alerts (https://github.com/TryGhost/Admin/pull/242) - [x] update the `type` property of upgrade notifications so that they are displayed using the default "info" alert styles (https://github.com//pull/7308)The text was updated successfully, but these errors were encountered: