Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expired invitations #8055

Closed
JohnONolan opened this issue Feb 27, 2017 · 1 comment · Fixed by TryGhost/Admin#550
Closed

Expired invitations #8055

JohnONolan opened this issue Feb 27, 2017 · 1 comment · Fixed by TryGhost/Admin#550
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@JohnONolan
Copy link
Member

JohnONolan commented Feb 27, 2017 •
edited by kirrg001
Loading

Shouldn't we automatically revoke expired invitations?

If that's not possible, the messaging should definitely change from "expires" to "expired"

image

Ghost: master
@JohnONolan JohnONolan added the bug [triage] something behaving unexpectedly label Feb 27, 2017
@kirrg001
Copy link
Contributor

I would suggest changing only the messaging for now, because the user can revoke manually.

@kirrg001 kirrg001 added affects:admin Anything relating to Ghost Admin help wanted [triage] Ideal issues for contributors to help with labels Feb 27, 2017
@kevinansfield kevinansfield self-assigned this Feb 27, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Feb 27, 2017
@kevinansfield
🐛 display correct expired/expires text for invites
606911d 
closes TryGhost/Ghost#8055
- use `expired` if the date is in the past, otherwise `expires`
- fix mirage factories to use `moment.valueOf` instead of `moment.unix` for invite `expires` attributes
@kevinansfield kevinansfield mentioned this issue Feb 27, 2017
Merged
@kirrg001 kirrg001 removed the help wanted [triage] Ideal issues for contributors to help with label Feb 27, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Feb 27, 2017
@kevinansfield
🐛 display correct expired/expires text for invites
5bde32c 
closes TryGhost/Ghost#8055
- use `expired` if the date is in the past, otherwise `expires`
- fix mirage factories to use `moment.valueOf` instead of `moment.unix` for invite `expires` attributes
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue Feb 27, 2017
@kevinansfield @kirrg001
🐛 display correct expired/expires text for invites (#550)
90be933 
closes TryGhost/Ghost#8055

- use `expired` if the date is in the past, otherwise `expires`
- fix mirage factories to use `moment.valueOf` instead of `moment.unix` for invite `expires` attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 display correct expired/expires text for invites kevinansfield/Ghost-Admin
3 participants
@kevinansfield @JohnONolan @kirrg001