Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cards need unique classes #8179

Closed
JohnONolan opened this issue Mar 16, 2017 · 1 comment
Closed

Cards need unique classes #8179

JohnONolan opened this issue Mar 16, 2017 · 1 comment
Assignees
@disordinary
Labels
affects:editor Work relating to the Koenig Editor

Comments

@JohnONolan
Copy link
Member

Can we have our own global card class? Eg. .koenig-card or maybe .kg-card rather than .__mobiledoc-card ?

More importantly though, definitely need card-type classes, eg. .kg-card-image / .kg-card-markdown / .kg-card-html etc
@JohnONolan JohnONolan added the affects:editor Work relating to the Koenig Editor label Mar 16, 2017
@disordinary
Copy link
Contributor

I started a refactor of mobiledoc-kit to allow custom classes but it turned out to be a bigger PITA than I was expecting and so I put it on hold, we can definitely insert class names at runtime though.

It is on my list to replace the existing mobiledoc classes though.

disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 17, 2017
@disordinary
✨ Add classes to card.
12e6281 
Closes: TryGhost/Ghost#8179

Previously all cards just had a `__mobiledoc-card` class on them, this update replaces them with a class `koenig-card` it also adds an additional class of `kg-{{card_name}}`
@disordinary disordinary mentioned this issue Mar 17, 2017
Merged
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 17, 2017
@disordinary
✨ Add classes to card.
36686b2 
Closes: TryGhost/Ghost#8179

Previously all cards just had a `__mobiledoc-card` class on them, this update replaces them with a class `koenig-card` it also adds an additional class of `kg-{{card_name}}`
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 18, 2017
@disordinary
✨ Add classes to card.
9951cbe 
Closes: TryGhost/Ghost#8179

Previously all cards just had a `__mobiledoc-card` class on them, this update replaces them with a class `koenig-card` it also adds an additional class of `kg-{{card_name}}`
kevinansfield pushed a commit to disordinary/Ghost-Admin that referenced this issue Mar 20, 2017
@disordinary @kevinansfield
✨ Add classes to card.
0c4eff5 
Closes: TryGhost/Ghost#8179

Previously all cards just had a `__mobiledoc-card` class on them, this update replaces them with a class `koenig-card` it also adds an additional class of `kg-{{card_name}}`
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Mar 20, 2017
@disordinary @kevinansfield
✨ Add classes to card. (#591)
41b035d 
closes: TryGhost/Ghost#8179
- previously all cards just had a `__mobiledoc-card` class on them, this update replaces them with a class `kg-card` and adds an additional class of `kg-{{card_name}}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@disordinary disordinary

Labels
affects:editor Work relating to the Koenig Editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@disordinary @JohnONolan