Pressing enter with blank link input crashes editor

[kevinansfield]

Issue Summary

I made some text a link and then wanted to remove it, I assumed I could do this by repeating the process and entering blank text for the link but that crashed the editor.

Steps to Reproduce

1. Highlight some text in the editor and use the popup menu to add a link
2. Select the same text and open the link input again
3. Press return to set a blank link value
4. Note the error in the console
5. Editor becomes unresponsive, every keypress results in another error

(note that the popups are partially hidden due to the proximity to the browser window edge rather than the screencap cutoff)

Technical details:

• Ghost Version: TryGhost/Admin@ab118ba
• Browser/OS: Chrome 57

[disordinary]

If you look at the background with the "Preview" button appearing, it seems to be creating a card the second time rather than a link.

[kevinansfield]

If you look at the background with the "Preview" button appearing, it seems to be creating a card the second time rather than a link.

I had a blank markdown card underneath the paragraph, it seems to break in a way that the "preview" hover text becomes part of the main content

[disordinary]

The issue isn't that applying the link twice causes chaos, it's that the focus isn't applied to the link input box but the editor has lost the windows selection after the first time that it is toggled.

Issues with the Range are by far the most common that we have with mobiledoc, I'm going to have to go through the mobiledoc code base at some stage and make sure that when editing operations happen it checks to make sure the range is valid, or at least catches these range errors properly. 😡