Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slash-menu not auto selecting when typing #8196

Closed
kevinansfield opened this issue Mar 20, 2017 · 0 comments
Closed

Slash-menu not auto selecting when typing #8196

kevinansfield opened this issue Mar 20, 2017 · 0 comments
Labels
affects:editor Work relating to the Koenig Editor

Comments

@kevinansfield
Copy link
Contributor

Steps to Reproduce

  1. Press / and start typing, eg. "bull"
  2. The number of matched options drops to one but it isn't selected
  3. Pressing enter throws an error and the slash menu popup disappears

no-slash-menu-selection

Technical details:
@kevinansfield kevinansfield added the affects:editor Work relating to the Koenig Editor label Mar 20, 2017
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Mar 21, 2017
@disordinary
🐜 Card Menu Default State Enter Action
bc97079 
The default state of both the '/' and '+' card menus is a selection of -1, this ensure that the active tool prompt isn't shown until the user presses an arrow key for keyboard selection. However -1 isn't a valid tool id so when pressing enter without selecting a tool the user will cause an error.

This update ensures that the selected tool is the first tool available even if the selection is in fact -1.

Closes: TryGhost/Ghost#8196
@disordinary disordinary mentioned this issue Mar 21, 2017
Merged
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Mar 21, 2017
@disordinary @kevinansfield
🐜 Card Menu Default State Enter Action (#600)
446551b 
closes TryGhost/Ghost#8196

The default state of both the '/' and '+' card menus is a selection of -1, this ensure that the active tool prompt isn't shown until the user presses an arrow key for keyboard selection. However -1 isn't a valid tool id so when pressing enter without selecting a tool the user will cause an error.

This update ensures that the selected tool is the first tool available even if the selection is in fact -1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:editor Work relating to the Koenig Editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinansfield