Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Title issues #8292

Closed
2 tasks done
disordinary opened this issue Apr 7, 2017 · 0 comments
Closed
2 tasks done

Editor Title issues #8292

disordinary opened this issue Apr 7, 2017 · 0 comments

Comments

@disordinary
Copy link
Contributor

disordinary commented Apr 7, 2017 •
edited
Loading

There are issues with the title:

  • 1. The ::after psuedo element is sitting on top of the cursor
  • 2. On key press the title looses the .empty class even if it has no content.
disordinary added a commit to disordinary/Ghost-Admin that referenced this issue Apr 7, 2017
@disordinary
Ensure the empty content psuedo element is always below the cursor an…
d192035 
…d make sure it always displays when the title is blank.

Closes: TryGhost/Ghost#8292
@disordinary disordinary mentioned this issue Apr 7, 2017
Merged
kevinansfield pushed a commit to disordinary/Ghost-Admin that referenced this issue Apr 7, 2017
@disordinary @kevinansfield
Ensure the empty content psuedo element is always below the cursor an…
d263ef7 
…d make sure it always displays when the title is blank.

Closes: TryGhost/Ghost#8292
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue Apr 7, 2017
@disordinary @kevinansfield
Editor title improvements (#614)
eb9e772 
closes: TryGhost/Ghost#8292
- Title improvements:
- Clean up the connection between the editor and title.
- Encapsulate all title related events in the title component.
- Fix tab support.
- Fixed an issue where pressing up from an empty paragraph would select the title
- Ensure the empty content psuedo element is always below the cursor and make sure it always displays when the title is blank.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@disordinary