Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ghost considers my 4-character Facebook username to be invalid. #8296

Closed
folz opened this issue Apr 9, 2017 · 0 comments · Fixed by TryGhost/Admin#632
Closed

Ghost considers my 4-character Facebook username to be invalid. #8296

folz opened this issue Apr 9, 2017 · 0 comments · Fixed by TryGhost/Admin#632
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Milestone
0.11.9

Comments

@folz
Copy link
Contributor

folz commented Apr 9, 2017 •
edited
Loading

Steps to Reproduce

  1. Navigate to /ghost/settings/general/ and scroll down to the Facebook Page setting
  2. Enter my Facebook URL, https://www.facebook.com/folz

What I expected to happen:

I would be able to configure my Facebook URL in the settings.

What actually happened:

I received the error message "Your Page name is not a valid Facebook Page name"

Looking at the relevant validation in app/controllers/settings/general.js, this appears to be intentional. However, this means you're excluding some people who worked at Facebook from linking their profile, as current/former FB employees are allowed to have usernames under 5 characters. Also, some brands have Page usernames under 5 characters (ex: https://www.facebook.com/nike).

Technical details:

  • Ghost Version: Pro
  • Node Version: Unsure, using Pro
  • Browser/OS: Firefox on Linux
  • Database: Unsure, using Pro
@folz folz mentioned this issue Apr 10, 2017
Merged
@kirrg001 kirrg001 added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly help wanted [triage] Ideal issues for contributors to help with labels May 12, 2017
kevinansfield pushed a commit to kevinansfield/Ghost-Admin that referenced this issue May 15, 2017
@folz @kevinansfield
🐛 permit Facebook usernames with less than 5 chars
9dc7504 
closes TryGhost/Ghost#8296
- permit Facebook usernames with less than 5 chars
    - brands are allowed to have Page names with less than 5 chars (ex: facebook.com/nike)
    - current/former employees are allowed to have usernames with less than 5 chars (ex: facebook.com/zuck)
@kevinansfield kevinansfield mentioned this issue May 15, 2017
Merged
@kirrg001 kirrg001 removed the help wanted [triage] Ideal issues for contributors to help with label May 15, 2017
@kirrg001 kirrg001 added this to the 0.11.9 milestone May 15, 2017
kevinansfield pushed a commit to kevinansfield/Ghost-Admin that referenced this issue May 15, 2017
@folz @kevinansfield
🐛 permit Facebook usernames with less than 5 chars
3efeed5 
closes TryGhost/Ghost#8296
- permit Facebook usernames with less than 5 chars
    - brands are allowed to have Page names with less than 5 chars (ex: facebook.com/nike)
    - current/former employees are allowed to have usernames with less than 5 chars (ex: facebook.com/zuck)
kevinansfield pushed a commit to TryGhost/Admin that referenced this issue May 15, 2017
@folz @kevinansfield
🐛 permit Facebook usernames with less than 5 chars (#632)
7457ffb 
refs TryGhost/Ghost#8296
- permit Facebook usernames with less than 5 chars
    - brands are allowed to have Page names with less than 5 chars (ex: facebook.com/nike)
    - current/former employees are allowed to have usernames with less than 5 chars (ex: facebook.com/zuck)
kevinansfield pushed a commit to kevinansfield/Ghost-Admin that referenced this issue May 16, 2017
@folz @kevinansfield
🐛 permit Facebook usernames with less than 5 chars
8977a61 
closes TryGhost/Ghost#8296
- permit Facebook usernames with less than 5 chars
    - brands are allowed to have Page names with less than 5 chars (ex: facebook.com/nike)
    - current/former employees are allowed to have usernames with less than 5 chars (ex: facebook.com/zuck)
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue May 16, 2017
@kevinansfield @kirrg001
🐛 permit Facebook usernames with less than 5 chars (#693)
e40eda1 
closes TryGhost/Ghost#8296

- permit Facebook usernames with less than 5 chars
    - brands are allowed to have Page names with less than 5 chars (ex: facebook.com/nike)
    - current/former employees are allowed to have usernames with less than 5 chars (ex: facebook.com/zuck)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
0.11.9
Development

Successfully merging a pull request may close this issue.

Permit Facebook usernames with less than 5 chars.
3 participants
@kevinansfield @folz @kirrg001