Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saved button shows "retry" for correct password change #8358

Closed
ErisDS opened this issue Apr 19, 2017 · 0 comments · Fixed by TryGhost/Admin#659
Closed

Saved button shows "retry" for correct password change #8358

ErisDS opened this issue Apr 19, 2017 · 0 comments · Fixed by TryGhost/Admin#659
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Milestone
1.0.0 Beta Ready

Comments

@ErisDS
Copy link
Member

ErisDS commented Apr 19, 2017 •
edited
Loading

When changing password in Ghost admin / team, the password is updated successfully and there is a green notification, however the button reads "retry"

Steps to Reproduce

  1. Visit the team page
  2. Enter your old password and a different new password
  3. Press save changes
  4. See the odd success notification & retry combo
  5. Logout and find that your password really did change

P.S. that little green success notification never goes away.

Technical details:

  • Ghost Version: Alpha 19
  • Node Version: 6.10.2
  • Browser/OS: Mac OS Chrome
  • Database: MySQL
@ErisDS ErisDS added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Apr 19, 2017
@kevinansfield kevinansfield self-assigned this Apr 19, 2017
@kevinansfield kevinansfield added this to the 1.0.0 Beta Ready milestone Apr 19, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Apr 19, 2017
@kevinansfield
🐛 fix password change button not showing success state
e85ed4a 
closes TryGhost/Ghost#8358
- the change password task was not returning a truthy value on success so you always saw the "X Retry" state
- adds option to pass `idleClass` and `runningClass` to `gh-task-button` - this is so that colour classes can be set in the "base" state without overriding the success/failure colors (some colours would have preference based on the order the colours are defined in the CSS file, eg. setting `gh-btn-red` as a base CSS class would override the `gh-btn-green` that is added after a successful save)
@kevinansfield kevinansfield mentioned this issue Apr 19, 2017
Merged
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue Apr 19, 2017
@kevinansfield @kirrg001
🐛 fix password change button not showing success state (#659)
48c45aa 
closes TryGhost/Ghost#8358

- the change password task was not returning a truthy value on success so you always saw the "X Retry" state
- adds option to pass `idleClass` and `runningClass` to `gh-task-button` - this is so that colour classes can be set in the "base" state without overriding the success/failure colors (some colours would have preference based on the order the colours are defined in the CSS file, eg. setting `gh-btn-red` as a base CSS class would override the `gh-btn-green` that is added after a successful save)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
1.0.0 Beta Ready
Development

Successfully merging a pull request may close this issue.

🐛 fix password change button not showing success state kevinansfield/Ghost-Admin
2 participants
@kevinansfield @ErisDS