Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for spellcheck #8461

Closed
kevinansfield opened this issue May 16, 2017 · 0 comments · Fixed by TryGhost/Admin#697
Closed

Add toggle for spellcheck #8461

kevinansfield opened this issue May 16, 2017 · 0 comments · Fixed by TryGhost/Admin#697
Assignees
Labels
affects:admin Anything relating to Ghost Admin

Comments

@kevinansfield
Copy link
Contributor

With the new SimpleMDE / CodeMirror backed editor there's no native spellcheck and the spellcheck which is implemented is via typo.js which only has a basic US English dictionary.

To avoid frustrations when writing non-english posts or from overaggressive marking of unknown words we should add a spellcheck toggle button to the editor toolbar.

@kevinansfield kevinansfield added the affects:admin Anything relating to Ghost Admin label May 16, 2017
@kevinansfield kevinansfield self-assigned this May 16, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue May 16, 2017
closes TryGhost/Ghost#8461
- adds toggle spellcheck button to the `gh-markdown-editor` toolbar
- adds custom styles to fake a spellcheck icon
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue May 17, 2017
closes TryGhost/Ghost#8461
- adds toggle spellcheck button to the `gh-markdown-editor` toolbar
- adds custom styles to fake a spellcheck icon
- updates `simplemde` fork
  - adds `spellcheck` to the list of toolbar buttons that don't have their `active` class removed based on cursor position
  - removes bundled `marked` dependency that we no longer use
aileen pushed a commit to TryGhost/Admin that referenced this issue May 18, 2017
closes TryGhost/Ghost#8461
- adds toggle spellcheck button to the `gh-markdown-editor` toolbar
- adds custom styles to fake a spellcheck icon
- updates `simplemde` fork
  - adds `spellcheck` to the list of toolbar buttons that don't have their `active` class removed based on cursor position
  - removes bundled `marked` dependency that we no longer use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects:admin Anything relating to Ghost Admin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant