Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Injection screen interferes with editor #8488

Closed
kevinansfield opened this issue May 29, 2017 · 0 comments · Fixed by TryGhost/Admin#717
Closed

Code Injection screen interferes with editor #8488

kevinansfield opened this issue May 29, 2017 · 0 comments · Fixed by TryGhost/Admin#717
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Contributor

Issue Summary

If you visit the Code Injection screen then some editor styles are overridden resulting in much larger text, some text not being visible until being clicked, and a weird scrollbar bug.

Steps to Reproduce

  1. Launch the admin and open a post in the editor, note the font size and what's visible
  2. Click the Code Injection link in the nav bar
  3. Press the back button or navigate to the post you previously viewed, note the change in font size and possible bugs with disappearing text and scrollbars

codemirror-interferance

Technical details:

  • Ghost Version: master
  • Browser/OS: Chrome / macOS
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels May 29, 2017
@kevinansfield kevinansfield self-assigned this May 29, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue May 29, 2017
@kevinansfield
🐛 fix lazy-loading of CodeMirror interfering with editor
26b83ea 
closes TryGhost/Ghost#8488
- don't lazy-load the CodeMirror styles in `gh-cm-editor` as they are already loaded and overridden
@kevinansfield kevinansfield mentioned this issue May 29, 2017
Merged
kirrg001 pushed a commit to TryGhost/Admin that referenced this issue May 30, 2017
@kevinansfield @kirrg001
🐛 fix lazy-loading of CodeMirror interfering with editor (#717)
0d40a60 
closes TryGhost/Ghost#8488

- don't lazy-load the CodeMirror styles in `gh-cm-editor` as they are already loaded and overridden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix lazy-loading of CodeMirror interfering with editor kevinansfield/Ghost-Admin
1 participant
@kevinansfield