Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content screen shortcuts interfere with filter dropdowns #8662

Closed
kevinansfield opened this issue Jul 7, 2017 · 0 comments · Fixed by TryGhost/Admin#775
Closed

Content screen shortcuts interfere with filter dropdowns #8662

kevinansfield opened this issue Jul 7, 2017 · 0 comments · Fixed by TryGhost/Admin#775
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Jul 7, 2017 •
edited

Issue Summary

When using the search inputs in the filter dropdowns the post route shortcuts interfere. If you press c you'll be taken to the new post route, and k & j aren't usable.

Steps to Reproduce

  1. Open the content screen
  2. Click on of the filter dropdowns
  3. Start typing in the filter search
  4. Note that it's not possible to enter k or j
  5. Press c, note that you are instantly taken to a new post screen

Potential solutions

  1. Remove the keyboard shortcuts - up/down/k/j and the associated enter/ctrl/cmd+backpace aren't very useful with the new content screen, especially at the moment where there's no immediate selection so pressing any of those keys has no action, the "active" post styling is also very subtle (I thought it was a rendering bug when I saw it 🙈).
    I'm not sure how often the c shortcut is used, I haven't heard anyone mention it before so maybe safe to remove? We could look at adding an alternative back if we receive enough feedback
  2. Find a way to override all route shortcuts when the filter dropdowns are active (it appears EPS already overrides the up/down arrows for it's own use)

Technical details:

  • Ghost Version: beta.2
  • Browser/OS: Chrome / macOS
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Jul 7, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jul 7, 2017
@kevinansfield
🔥 remove content screen keyboard shortcuts
016d3f8 
closes TryGhost/Ghost#8662
- removes `k`, `j`, `up`, `down` shortcuts for changing the active post (these were already mostly unusable in 1.0) and the associated `enter` and `ctrl/cmd+backspace` commands for opening and triggering the delete modal respectively
- removes the `c` shortcut for opening the new post screen
@kevinansfield kevinansfield self-assigned this Jul 7, 2017
@kevinansfield kevinansfield mentioned this issue Jul 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔥 remove content screen keyboard shortcuts kevinansfield/Ghost-Admin
1 participant
@kevinansfield