Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing lock icons on password reset #8688

Closed
JohnONolan opened this issue Jul 14, 2017 · 3 comments · Fixed by TryGhost/Admin#782 or TryGhost/Admin#791
Closed

Missing lock icons on password reset #8688

JohnONolan opened this issue Jul 14, 2017 · 3 comments · Fixed by TryGhost/Admin#782 or TryGhost/Admin#791
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@JohnONolan
Copy link
Member

JohnONolan commented Jul 14, 2017 •
edited
Loading

On password reset screen there are icon-inputs with space for an icon, but no icon. These should either both have lock-icons (preferable) - or not have space for icons at all (acceptable)

Ghost 1.0-beta2

image
@JohnONolan JohnONolan added the bug [triage] something behaving unexpectedly label Jul 14, 2017
@kevinansfield kevinansfield added the affects:admin Anything relating to Ghost Admin label Jul 14, 2017
@JohnONolan
Copy link
Member Author

Also the page title seems to be broken

image

@JohnONolan
Copy link
Member Author

Also when submitting the form, the button goes loading => flashes a red error => then redirects successfully to admin

kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jul 15, 2017
@kevinansfield
🎨 fix missing lock icons on password reset form
6fe75e5 
closes TryGhost/Ghost#8688
- match input fields HTML to other icon inputs
@kevinansfield kevinansfield mentioned this issue Jul 15, 2017
Merged
@kevinansfield
Copy link
Contributor

Re-opening, I'd missed the red/retry flash before the redirect 😞 I'll PR a second fix shortly.

@kevinansfield kevinansfield reopened this Jul 20, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jul 20, 2017
@kevinansfield
🐛 fix "failed" button flash on password reset
bcaf57b 
closes TryGhost/Ghost#8688
- `reset` task wasn't returning a truthy value on success so `gh-task-button` flashed the "retry" state before the transition happened
@kevinansfield kevinansfield mentioned this issue Jul 20, 2017
Merged
aileen pushed a commit to TryGhost/Admin that referenced this issue Jul 20, 2017
@kevinansfield @aileen
🐛 fix "failed" button flash on password reset (#791)
33be8eb 
closes TryGhost/Ghost#8688
- `reset` task wasn't returning a truthy value on success so `gh-task-button` flashed the "retry" state before the transition happened
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
2 participants
@kevinansfield @JohnONolan