Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all items are visible in dropdown filters #8729

Closed
kevinansfield opened this issue Jul 21, 2017 · 0 comments · Fixed by TryGhost/Admin#796
Closed

Not all items are visible in dropdown filters #8729

kevinansfield opened this issue Jul 21, 2017 · 0 comments · Fixed by TryGhost/Admin#796
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Jul 21, 2017 •
edited

Issue Summary

NB: This actually affects all filters, not just the tags filter

The tags filter will only show 5 tags even though more tags exist, it doesn't become scrollable until more tags are added but even then not all tags are viewable. There is also an issue where spaces can appear in the filter that have no tag name.

tags-filter-bug

Steps to Reproduce

  1. Create a number of tags (in some tests I couldn't get any scroll in the filter until there were at least 17)
  2. Open the tags filter on the stories screen and try to scroll to see all available tags

Technical details:

  • Ghost Version: 1.0.0-rc.1
  • Browser/OS: Chrome/macOS
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Jul 21, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jul 21, 2017
@kevinansfield
🐛 fix filter dropdown issues
e4fb75b 
closes TryGhost/Ghost#8729, closes TryGhost/Ghost#8728
- remove the duplicated `max-height` rules for different parts of the power select dropdowns - they were interacting with each other and causing a large part of the lists to be unreachable
- filter the temporary tags that are created when using the PSM tags input so duplicates aren't visible in the tags dropdown filter
@kevinansfield kevinansfield mentioned this issue Jul 21, 2017
Merged
@kevinansfield kevinansfield changed the title Not all tags are visible in tags filter Not all items are visible in dropdown filters Jul 21, 2017
@kevinansfield kevinansfield self-assigned this Jul 21, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jul 21, 2017
@kevinansfield
🐛 fix filter dropdown issues
db01431 
closes TryGhost/Ghost#8729, closes TryGhost/Ghost#8728
- remove the duplicated `max-height` rules for different parts of the power select dropdowns - they were interacting with each other and causing a large part of the lists to be unreachable
- bump the `bufferSize` so that enough dropdown items are rendered to fill the dropdown list
- filter the temporary tags that are created when using the PSM tags input so duplicates aren't visible in the tags dropdown filter
acburdine pushed a commit to TryGhost/Admin that referenced this issue Jul 21, 2017
@kevinansfield @acburdine
🐛 fix filter dropdown issues
c4ad8b7 
closes TryGhost/Ghost#8729, closes TryGhost/Ghost#8728
- remove the duplicated `max-height` rules for different parts of the power select dropdowns - they were interacting with each other and causing a large part of the lists to be unreachable
- bump the `bufferSize` so that enough dropdown items are rendered to fill the dropdown list
- filter the temporary tags that are created when using the PSM tags input so duplicates aren't visible in the tags dropdown filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 fix filter dropdown issues kevinansfield/Ghost-Admin
1 participant
@kevinansfield