Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor split screen mode is lost when saving new post #8750

Closed
kevinansfield opened this issue Jul 25, 2017 · 0 comments · Fixed by TryGhost/Admin#949
Closed

Editor split screen mode is lost when saving new post #8750

kevinansfield opened this issue Jul 25, 2017 · 0 comments · Fixed by TryGhost/Admin#949
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Contributor

Issue Summary

If you start a new post and enter split screen mode before a save is triggered the first autosave kicks you out of split screen.

Steps to Reproduce

  1. Click New story
  2. Click the side-by-side preview button in the editor toolbar
  3. Start typing
  4. Note that once the autosave has completed you're kicked out of the side-by-side preview

Technical details:

  • Ghost Version: 1.0.0
  • Browser/OS: Chrome/macOS
@kevinansfield kevinansfield added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Jul 25, 2017
@disordinary disordinary mentioned this issue Oct 9, 2017
Closed
1 task
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jan 16, 2018
@kevinansfield
Refactor new->edit transition to avoid editor re-renders
ae2a035 
closes TryGhost/Ghost#8287
closes TryGhost/Ghost#8750
- moved all editor model functionality into the new `editor` route+controller
- moved editor template from `editor/edit.hbs` to `editor.hbs`
- refactored `editor` controller and the `editor.new`/`editor.edit` routes to work with a persistent editor rather than a teardown/re-render when transitioning from new->edit
- fixed issue in `{{gh-markdown-editor}}` for `autofocus` behaviour when the component isn't re-rendered
- fixed issue in `{{gh-simplemde}}` that was causing multiple updates to the `value` property when a new value is passed in to the component
- added `{{gh-scheduled-post-countdown}}` component to lower the noise in the editor controller
- removed editor route/controller mixins
- removed the `editor.edit` and `editor.new` controllers
@kevinansfield kevinansfield mentioned this issue Jan 16, 2018
Merged
1 task
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Jan 16, 2018
@kevinansfield
Refactor new->edit transition to avoid editor re-renders
2ce3f57 
closes TryGhost/Ghost#8287
closes TryGhost/Ghost#8750
- moved all editor model functionality into the new `editor` route+controller
- moved editor template from `editor/edit.hbs` to `editor.hbs`
- refactored `editor` controller and the `editor.new`/`editor.edit` routes to work with a persistent editor rather than a teardown/re-render when transitioning from new->edit
- fixed issue in `{{gh-markdown-editor}}` for `autofocus` behaviour when the component isn't re-rendered
- fixed issue in `{{gh-simplemde}}` that was causing multiple updates to the `value` property when a new value is passed in to the component
- added `{{gh-scheduled-post-countdown}}` component to lower the noise in the editor controller
- removed editor route/controller mixins
- removed the `editor.edit` and `editor.new` controllers
kevinansfield added a commit to TryGhost/Admin that referenced this issue Jan 17, 2018
@kevinansfield
Refactor new->edit transition to avoid editor re-renders (#949)
51e890b 
closes TryGhost/Ghost#8287
closes TryGhost/Ghost#8750
- moved all editor model functionality into the new `editor` route+controller
- moved editor template from `editor/edit.hbs` to `editor.hbs`
- refactored `editor` controller and the `editor.new`/`editor.edit` routes to work with a persistent editor rather than a teardown/re-render when transitioning from new->edit
- fixed issue in `{{gh-markdown-editor}}` for `autofocus` behaviour when the component isn't re-rendered
- fixed issue in `{{gh-simplemde}}` that was causing multiple updates to the `value` property when a new value is passed in to the component
- added `{{gh-scheduled-post-countdown}}` component to lower the noise in the editor controller
- removed editor route/controller mixins
- removed the `editor.edit` and `editor.new` controllers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor new->edit transition to avoid editor re-renders kevinansfield/Ghost-Admin
1 participant
@kevinansfield