Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsplash "retry" link on failed request throws error #9041

Closed
kevinansfield opened this issue Sep 22, 2017 · 0 comments · Fixed by TryGhost/Admin#875
Closed

Unsplash "retry" link on failed request throws error #9041

kevinansfield opened this issue Sep 22, 2017 · 0 comments · Fixed by TryGhost/Admin#875
Assignees
@kevinansfield
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@kevinansfield
Copy link
Contributor

Issue Summary

When an Unsplash API request fails, clicking the retry link throws an error.

Steps to Reproduce

  1. Open a post in the admin editor
  2. Use Chrome's network tools to simulate "offline" mode
  3. Click the Unsplash icon in the editor toolbar
  4. Click the "retry" link in the error message.
  5. The following error is thrown:

screen shot 2017-09-22 at 13 47 42

Technical details:

  • Ghost Version: 1.9.0
  • Browser/OS: Chrome latest/macOS
@kirrg001 kirrg001 added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly labels Sep 22, 2017
@kevinansfield kevinansfield self-assigned this Sep 27, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Sep 27, 2017
@kevinansfield
🐛 Fixed broken "retry" link when an Unsplash API request failed
faea561 
closes TryGhost/Ghost#9041
- add missing public `retryLastRequest()` method to Unsplash service
@kevinansfield kevinansfield mentioned this issue Sep 27, 2017
Merged
aileen pushed a commit to TryGhost/Admin that referenced this issue Sep 28, 2017
@kevinansfield @aileen
🐛 Fixed broken "retry" link when an Unsplash API request failed (#875)
4e5fda2 
closes TryGhost/Ghost#9041

- add missing public `retryLastRequest()` method to Unsplash service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinansfield kevinansfield

Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fixed broken "retry" link when an Unsplash API request failed kevinansfield/Ghost-Admin
2 participants
@kevinansfield @kirrg001