Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Uploads of redirects file fail #9266

Closed
jloh opened this issue Nov 21, 2017 · 2 comments · Fixed by TryGhost/Admin#912
Closed

Multiple Uploads of redirects file fail #9266

jloh opened this issue Nov 21, 2017 · 2 comments · Fixed by TryGhost/Admin#912
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly

Comments

@jloh
Copy link
Member

jloh commented Nov 21, 2017

Issue Summary

When uploading new redirects.json files the first one happens fine however additional uploads prompt for a file, then do nothing. Confirmed no file is being uploaded via networks tab.

Steps to Reproduce

  1. Upload a valid redirects.json file and confirm its accepted
  2. Attempt to upload a second redirects.json file and see nothing happens (confirm via network debugger)

Unsure if its related but I do see this error printed out on the FF console:

09:44:53.165 SyntaxError: expected expression, got '<'
[Learn More]
pro-cta.js:1

Technical details:

  • Ghost Version: 1.17.2 (Ghost Pro)
  • Node Version: Unknown
  • Browser/OS: Firefox 57.0 (64 bit) OSX
  • Database: MySQL
@aileen
Copy link
Member

aileen commented Nov 22, 2017

@kirrg001 I am not able to reproduce this in my local environment.

@aileen aileen added the needs:info [triage] Blocked on missing information label Nov 22, 2017
@kirrg001
Copy link
Contributor

I can reproduce in FF. Didn't test with Chrome or Safari. I had to refresh the page to be able to upload the same redirects file again.

@kirrg001 kirrg001 removed their assignment Nov 22, 2017
@kirrg001 kirrg001 added affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly and removed needs:info [triage] Blocked on missing information labels Nov 22, 2017
kevinansfield added a commit to kevinansfield/Ghost-Admin that referenced this issue Nov 22, 2017
@kevinansfield
🐛 Fixed inability to re-upload the same redirects file
90a5779 
closes TryGhost/Ghost#9266
- `emberx-file-input` passes a `resetInput` function through to it's action handler but we weren't doing that in our override component. Added the missing functionality and updated all of our handlers to use that instead of doing manual resets
- added a `setFiles` action to `{{gh-uploader}}` and yield it for use in block invocations
@kevinansfield kevinansfield mentioned this issue Nov 22, 2017
Merged
kevinansfield added a commit to TryGhost/Admin that referenced this issue Nov 22, 2017
@kevinansfield
🐛 Fixed inability to re-upload the same redirects file (#912)
74428ef 
closes TryGhost/Ghost#9266
- `emberx-file-input` passes a `resetInput` function through to it's action handler but we weren't doing that in our override component. Added the missing functionality and updated all of our handlers to use that instead of doing manual resets
- added a `setFiles` action to `{{gh-uploader}}` and yield it for use in block invocations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects:admin Anything relating to Ghost Admin bug [triage] something behaving unexpectedly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Fixed inability to re-upload the same redirects file kevinansfield/Ghost-Admin
3 participants
@kirrg001 @jloh @aileen