Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ghost eslint plugin #9834

Closed
kirrg001 opened this issue Aug 29, 2018 · 2 comments
Closed

Use ghost eslint plugin #9834

kirrg001 opened this issue Aug 29, 2018 · 2 comments
Labels
help wanted [triage] Ideal issues for contributors to help with server / core Issues relating to the server or core of Ghost

Comments

@kirrg001
Copy link
Contributor

A couple of month ago we have created a Ghost eslint plugin..

It's used already in a couple of places, but not on the server side 👻✌🏻

You can take a look at this commit and follow the steps to replace the code with the new plugin.
@kirrg001 kirrg001 added server / core Issues relating to the server or core of Ghost help wanted [triage] Ideal issues for contributors to help with tools labels Aug 29, 2018
@lunaticmonk lunaticmonk mentioned this issue Aug 29, 2018
Merged
3 tasks
lunaticmonk added a commit to lunaticmonk/Ghost that referenced this issue Sep 17, 2018
@lunaticmonk
♻️ Use ghost eslint plugin in server side code (TryGhost#9834)
0b881ea
kirrg001 pushed a commit that referenced this issue Sep 17, 2018
@lunaticmonk @kirrg001
Switched to eslint-plugin-ghost (#9835)
efd1587 
refs #9834

- @todo: the test env eslint needs to use the plugin, not part of this PR
@kirrg001
Copy link
Contributor Author

There is one missing task: Replace the eslint file in the test env 👻

@lunaticmonk
Copy link
Contributor

@kirrg001 will open another pr for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted [triage] Ideal issues for contributors to help with server / core Issues relating to the server or core of Ghost
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErisDS @kirrg001 @lunaticmonk