🐛 Fixed known filter limitations #10159

kirrg001 · 2018-11-13T14:49:05Z

Tasks

core/server/models/plugins/filter.js

core/test/functional/api/v2/content/posts_spec.js

core/server/models/plugins/filter.js

refs #10105 - `options.where` is an older deprecated logic - before the filter language was invented, Ghost generates statements for knex - if we want to replace GQL with NQL, we can't generate these statements - they are not understood from NQL, because NQL uses mongo JSON - go through usages and rewrite the statements - invent `extraFilters` for now - we need to keep the support for `status` or `staticPages` for now (API requirement) - IMO both shortcuts in the extra filters should be removed in the future This commit is required for #10159!

kirrg001 · 2018-11-15T15:32:39Z

@gargol Could you pls work on getting rid of the functions preProcessFilters and postProcessFilters.

The goal should be to enable existing test cases which used these two filters in the past. If you can't find a test case, add one for now as functional test.

The test cases will be restricted by the functionality of mongo-knex..

You might need to adapt the filter plugin or the model layer to make them work.

I will work on finishing up TryGhost/mongo-knex#16.

naz · 2018-11-15T15:59:40Z

Sure, starting on preProcessFilters and postProcessFilters now.

core/server/models/plugins/filter.js

core/server/models/post.js

core/test/functional/api/v0.1/posts_spec.js

core/server/models/plugins/filter.js

core/test/unit/models/tag_spec.js

core/test/unit/models/plugins/filter_spec.js

core/test/unit/models/post_spec.js

- you need to install v0.2.0 mongo-knex

- extend existing test

- e.g. if you pass an unknown column -> filter=test:en

- we only tested simple cases e.g. you pass `filter=page:true` - but any complex use case e.g. like `filter=(page:true,page:false)` will result in a parse error - we have to simplify this behaviour

kirrg001 · 2018-12-11T10:46:21Z

Travis is failing because of a random failure, tracked in #7470 again 🤨
Will merge anyway!

refs #10105 - `options.where` is an older deprecated logic - before the filter language was invented, Ghost generates statements for knex - if we want to replace GQL with NQL, we can't generate these statements - they are not understood from NQL, because NQL uses mongo JSON - go through usages and rewrite the statements - invent `extraFilters` for now - we need to keep the support for `status` or `staticPages` for now (API requirement) - IMO both shortcuts in the extra filters should be removed in the future This commit is required for TryGhost/Ghost#10159!

naz reviewed Nov 13, 2018

View reviewed changes

core/server/models/plugins/filter.js Show resolved Hide resolved

kirrg001 mentioned this pull request Nov 13, 2018

Replace GQL with NQL (filter plugin) #10105

Closed

18 tasks

kirrg001 force-pushed the replace-gql branch 2 times, most recently from 8106f1b to 43f833d Compare November 13, 2018 17:22

kirrg001 commented Nov 13, 2018

View reviewed changes

core/test/functional/api/v2/content/posts_spec.js Outdated Show resolved Hide resolved

kirrg001 commented Nov 13, 2018

View reviewed changes

core/server/models/plugins/filter.js Outdated Show resolved Hide resolved

kirrg001 changed the title ~~[WIP] Replaced GQL with NQL~~ [HOLD/WIP] Replaced GQL with NQL Nov 13, 2018

kirrg001 mentioned this pull request Nov 15, 2018

✨ Added support for filtering by multiple relation columns TryGhost/mongo-knex#15

Merged

kirrg001 force-pushed the replace-gql branch 2 times, most recently from 7db2913 to ee5ac5a Compare November 15, 2018 14:55

kirrg001 mentioned this pull request Nov 15, 2018

Moved raw order for author filtering to correct place (#10166) #10171

Merged

kirrg001 force-pushed the replace-gql branch from 6cb2c17 to a28ab4a Compare November 15, 2018 15:18