Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated backup file names to include timestamp #10607

Merged
merged 3 commits into from Mar 13, 2019
Merged

Updated backup file names to include timestamp #10607

merged 3 commits into from Mar 13, 2019

Conversation

allouis
Copy link
Contributor

@allouis allouis commented Mar 13, 2019

no-issue

Currently if you run two migrations on the same day, the backup is overwritten. This change adds the HH-mm-ss to the file name, meaning that you get a unique backup for each migration.

@allouis allouis merged commit 56b6c63 into TryGhost:master Mar 13, 2019
@kirrg001
Copy link
Contributor

kirrg001 commented Mar 13, 2019 •
edited

Looks good. Format is not peeerfect, but alternative is not really better e.g. timestamp

@allouis allouis deleted the update-backup-naming branch March 13, 2019 20:06
allouis added a commit that referenced this pull request Mar 13, 2019
@allouis
Merge branch 'master' @ 2.18.0 into stable
e4a8edd 
* master:
  Version bump to 2.18.0
  Updated Ghost-Admin to 2.18.0
  Improved error messages/handling for 2.18 migrations (#10608)
  🐛  Fixed private blogging getting disabled after 2.17 migration (#10606)
  Updated backup file names to include timestamp (#10607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allouis @kirrg001