Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Reverted: Fixed image URL to be stored as relative in mobiledoc #10632

Closed
wants to merge 1 commit into from
Closed

[WIP] Reverted: Fixed image URL to be stored as relative in mobiledoc #10632

wants to merge 1 commit into from

Conversation

kirrg001
Copy link
Contributor

refs #10477, refs #10620

Case:

  • editor uploads an image
  • receives absolute path
  • inserts into mobiledoc
  • updates post
  • server stores relative asset paths
  • we need to serve absolute asset paths, otherwise, editor could mark content as "dirty"

@kirrg001 kirrg001 mentioned this pull request Mar 22, 2019
Closed
@kirrg001 kirrg001 changed the title Reverted: Fixed image URL to be stored as relative in mobiledoc [WIP] Reverted: Fixed image URL to be stored as relative in mobiledoc Mar 22, 2019
@kirrg001
Copy link
Contributor Author

This is not a full solution, html is generated based on mobiledoc.

@kirrg001
Copy link
Contributor Author

This is not a full solution, html is generated based on mobiledoc.

Will take too long now. Closing.

Will sum up the mobiledoc problems on #10477.

@kirrg001 kirrg001 closed this Mar 22, 2019
@kirrg001 kirrg001 mentioned this pull request Mar 22, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kirrg001