Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix naming convention for unoptimized versions of images #10970

Closed
wants to merge 3 commits into from

Conversation

1DxSU1t6
Copy link

@1DxSU1t6 1DxSU1t6 commented Aug 1, 2019

refs #10912

This is a draft proposal for fixing the references issue – please provide feedback.

@rishabhgrg rishabhgrg requested a review from allouis August 1, 2019 10:57
@allouis
Copy link
Contributor

allouis commented Aug 2, 2019

@1DxSU1t6 Hey! Super appreciate this work ☺️ I will be taking some time on Monday to look at this 💃

@1DxSU1t6
Copy link
Author

1DxSU1t6 commented Aug 6, 2019

Hi @allouis , have you had a chance to take a look at this yet?

@allouis
Copy link
Contributor

allouis commented Aug 6, 2019

Hey @1DxSU1t6!

So far this looks good, I'll be interested to see what the migrations look like.

One thing I would mention is that this seems to add a feature of retreiving the original image, which we don't currently have. I think it adds noise to this PR (it's quite a complex system atm and the less we have to think about, the easier IMO) and should be included in a separate PR after this work has been done - what do you think?

@1DxSU1t6
Copy link
Author

1DxSU1t6 commented Aug 6, 2019

@allouis thanks for taking a look! I will work on the migration in the coming days.

I agree re. moving the added feature in a separate PR, however that's actually one of my main motivations of working on this ;) I would like to use imgix for my images for a blog hosted on Ghost Pro, and the only way to accomplish that is to provide a way to access original images at a stable URL. So I'll split it, but I'd greatly appreciate if you'd review and consider merging the other PR too.

@naz
Copy link
Member

naz commented Oct 30, 2019

Hey, @1DxSU1t6 any updates? 😉

@naz
Copy link
Member

naz commented Jan 6, 2020

Doing a little start of the year cleanup here. @1DxSU1t6 or anybody who comes around the issue feel free to pick up where it was left off:wink:

@naz naz closed this Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants