馃彈 Migrated subscribers data to members #11152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naz
commented
Sep 24, 2019
core/server/data/migrations/versions/3.0/12-populate-members-table-from-subscribers.js
Show resolved
Hide resolved
allouis
requested changes
Sep 25, 2019
| common.logging.info(`Adding ${subscribers.length} entries to subscribers`); | ||
|
|
||
| let members = _.map(subscribers, (subscriber) => { | ||
| let member = memberAttrs.reduce(function (obj, entry) { |
There was a problem hiding this comment.
If we end up adding columns to the members table which don't exist in subscribers this is gonna break I think?
It might be best to be explicit about what we're copying here: name, email, created_{at,by} update_{at,by}
There was a problem hiding this comment.
hm. good point. will update!
- If the members schema changes we don't want to copy over data without double checking it first
naz
added a commit
that referenced
this pull request
Oct 9, 2019
refs #11152 - Added subscribers table drop migration - Removed subscribers from schema - Removed subscribers controllers/routes/regression tests - Removed subscriber related API code - Removed subscribers from internal apps - Removed subscriber importer - Removed subscriber model - Removed subscriber related permissions - Removed webhook code related to subscribers - When upgrading to v3 it is on the site admin to migrate all zapps or any other webhook clients to use members - Removed subscriber-specific translation - Removed subscriber lab flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscribers be dead 馃拃 part uno
Heavily inspired (aka total rip-off) from 8ec12d9#diff-d8134e2685be7aa74ca7fda95443c6ef. As a follow up will be the removal of all subscriber related code (schema, app, flags, templates etc.)
Migration need 馃憖 on this. Thx!