Added member's subscription cancellation helper {{cancel_link}} #11434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allouis
approved these changes
Dec 4, 2019
@allouis good point on this one! Have added handling and added a text which needs a copy review: Also, have seen a console.error(err); in |
|
@gargol I think you can still nest the error element for now, just like we do with the |
We are listening to a button, so there's not much to be nested in I think. Will adjust as clearer wireframes are confirmed. For now, it's a rough prototype so is fine like this with a thought to be changed. |
|
This is how we currently document it for the So if we have this one as different then IMO we should maybe update the other stuff too |
Oh 😮 it makes sense! Good point! |
naz
force-pushed
the
members-cancel-subscription
branch
from
4a72f32
to
b5486fc
Compare
allouis
reviewed
Dec 6, 2019
naz
force-pushed
the
members-cancel-subscription
branch
from
4f1bdbc
to
ea3e6ed
Compare
naz
commented
Dec 9, 2019
| @@ -0,0 +1,25 @@ | |||
| const commands = require('../../../schema').commands; | |||
There was a problem hiding this comment.
@allouis & @rishabhgrg this commit has a tiny migration and some schema changes. Would need your 👍 for this as usual 😉
naz
force-pushed
the
members-cancel-subscription
branch
from
9bdf1ce
to
78b7d47
Compare
naz
added a commit
to TryGhost/Members
that referenced
this pull request
Dec 12, 2019
refs #TryGhost/Ghost#11434 - Added method to allow updating single subscription. Only `cancel_at_period_end` field can be updated. - Middleware is needed to allow Ghost Core to cancel/uncancel member's subscription. - Relies on the request containing identity information to be able to verify if subscription belongs to the user - When member could not be identified by the identity information present in the request we should throw instead of continuing processing - Handling and messaging inspired by https://github.com/TryGhost/Ghost/blob/3.1.1/core/server/services/mega/mega.js#L132 - When the user initiates subscription cancellation we can safely mark the subscription as canceled so that it's not shown in the interface on subsequent request. Otherwise, we end up in a situation where we still return the subscription in the period until Stripe triggers the webhook. - Added boolean coercion for cancel_at_period_end parameter. If anything but boolean is passed to Stripe API it throws an error. Coercing the value on our side is a gives a better dev experience
naz
added a commit
to TryGhost/gscan
that referenced
this pull request
Dec 12, 2019
refs TryGhost/Ghost#11434 - Added {{cancel_link}} to know helper in canary spec - Updated compile test structure to test version-specific changes - The previous structure only tested v1 spec and didn't take into account any new 'allowed helpers' - The new structure resembles one in deprecations and can be easily extended with new helpers on a per-version basis
- Allows to create elements with `data-members-cancel-subscription` attribute which would call subscription canellation
- This is more apporpriate palce for this endpoint.
…or' element - We are not inside the form, so there needs to be a separate element which would define where the error should be shown
- We need to store auto-renewal/cancellation state on our side to be able to display it to the member
- We need 2 states handled for subscription, for that reason PUT with a flag makes more sense than a DELETE
- As discussed we only add single column to subscriptions table to avoid preoptimizing for future cases
…continue-subscription
- This corresponds better to the intention of the action and matches parameter names for the {{cancel_link}} helper
- This is needed so that the check is also performed when the member flag in settings is toggled during runtime
… subscription context
- Needed to use `updateSubscription` middleware
- Needed to recognize new {{cancel_link}} helper
naz
force-pushed
the
members-cancel-subscription
branch
from
550866c
to
bbaf0ba
Compare
naz
changed the title
naz
added a commit
to TryGhost/Lyra
that referenced
this pull request
Dec 12, 2019
refs TryGhost/Ghost#11434 - Adds {{cancel_link}} use to the `account.hbs` page which allows to cancel or continue member's subscription. - Adds some subscription specific data on the account page to give more context to the member.
daniellockyer
pushed a commit
that referenced
this pull request
Jul 20, 2022
refs ##11434 - Added method to allow updating single subscription. Only `cancel_at_period_end` field can be updated. - Middleware is needed to allow Ghost Core to cancel/uncancel member's subscription. - Relies on the request containing identity information to be able to verify if subscription belongs to the user - When member could not be identified by the identity information present in the request we should throw instead of continuing processing - Handling and messaging inspired by https://github.com/TryGhost/Ghost/blob/3.1.1/core/server/services/mega/mega.js#L132 - When the user initiates subscription cancellation we can safely mark the subscription as canceled so that it's not shown in the interface on subsequent request. Otherwise, we end up in a situation where we still return the subscription in the period until Stripe triggers the webhook. - Added boolean coercion for cancel_at_period_end parameter. If anything but boolean is passed to Stripe API it throws an error. Coercing the value on our side is a gives a better dev experience
Eros720
added a commit
to Eros720/Lyra
that referenced
this pull request
Jun 6, 2023
refs TryGhost/Ghost#11434 - Adds {{cancel_link}} use to the `account.hbs` page which allows to cancel or continue member's subscription. - Adds some subscription specific data on the account page to give more context to the member.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs TryGhost/Members#107
data-members-cancel-subscriptionattribute.DELETE /subscriptions/:idwhich allows canceling membership by subscription_id@peterzimon the naming of the
data-members-cancel-subscriptionneeds confirmation. Also, currently reloading the page withwindow.location.reload();after the request succeeds, this flow needs some design input as well 😉@allouis would be great 🙌 if you could give a second pair of 👀 but we discussed this in the pitch enough I think 😃