Fixed published time and modified time for Structured data #12085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red data closes #12059 Published Time and Modified Time were not populating for 'page' context because it is an extension of 'post' and hence there was no context 'page'. Fixed it by handling this scenario for published time and modified time
…red data closes #12059 Published Time and Modified Time were not populating for 'page' context because it is an extension of 'post' and hence there was no context 'page'. Fixed it by using the common contextObject, and handled the scenario for the legacy post in page for contextObject. Should also fix some other missing parameters.
ErisDS
requested changes
Aug 3, 2020
There was a problem hiding this comment.
@roshandash411 thank you for this PR!
I wasn't expecting the getContextObject method to need adjusting, and I can't see a case where the extra if is needed.
If we can clean this up, this PR should be good to merge!
|
@ErisDS : Yeah you are right, my bad I had overlooked it. I have updated the PR with the fix. |
ErisDS
approved these changes
Aug 17, 2020
daniellockyer
pushed a commit
that referenced
this pull request
Aug 18, 2020
closes #12059 - Published Time and Modified Time were not populating for 'page' context because it is an extension of 'post' and hence there was no context 'page'. - Fixed it by using the common contextObject & `getContextObject` utility. - Should also fix some other missing parameters.
daniellockyer
added a commit
that referenced
this pull request
Aug 18, 2020
v3.29.2 * tag '3.29.2': v3.29.2 Updated Ghost-Admin to v3.29.2 🐛 Fixed failing migration from <2.34 to 3.29 🐛 Fixed published time and modified time for structured data (#12085) 🐛 Fixed meta data when using tag data in collection (#12137) Updated Stripe JS to load async in head 🐛 Removed [http://url/] output in member email preview text 🐛 Fixed apostrophes not displaying correctly in Outlook for member emails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12059
Published Time and Modified Time were not populating for 'page' context because it is an extension of 'post' and hence there was no context 'page'. Fixed it by handling this scenario for published time and modified time