Added new portal config flag #12211
Merged
Added new portal config flag #12211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhgrg
added a commit
to rishabhgrg/Ghost-Admin
that referenced
this pull request
Sep 17, 2020
no issue depends on TryGhost/Ghost#12211 - Other than dev flag, the Portal is now also enabled behind a dedicated `portal` flag - Shows/hides Portal settings based on dev or Portal flag
no issue - The new Portal config flag allows switching on Portal conditionally with config - The dev experiment flag still works for enabling Portal - The flag currently defaults to `false` as Portal is still a beta feature and switched off by default - We expose it on the admin api config endpoint so that the Ghost-Admin client can use it to conditionally render Portal settings
rishabhgrg
force-pushed
the
portal-dedicated-flag
branch
from
de8be47
to
784ba75
Compare
rishabhgrg
added a commit
to rishabhgrg/Ghost-Admin
that referenced
this pull request
Sep 17, 2020
no issue depends on TryGhost/Ghost#12211 - Other than dev flag, the Portal is now also enabled behind a dedicated `portal` flag - Shows/hides Portal settings based on dev or Portal flag
rishabhgrg
added a commit
to TryGhost/Admin
that referenced
this pull request
Sep 17, 2020
no issue depends on TryGhost/Ghost#12211 - Other than dev flag, the Portal is now also enabled behind a dedicated `portal` flag - Shows/hides Portal settings based on dev or Portal flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
falseas Portal is still a beta feature and switched off by default