Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward query params when redirect. #12333

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Nov 5, 2020

ref #10898

  • It parses query params and merge them and stringify it.
  • This PR ignores 2 cases: querystring in redirects definition and not passing through URL query params.

Got some code for us? Awesome 馃帄!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test and yarn lint)

More info can be found by clicking the "guidelines for contributing" link above.

ref TryGhost#10898

- It parses the query params and merge them and stringify the result.
@naz naz self-assigned this Jan 4, 2021
@naz naz merged commit 7528ec8 into TryGhost:master Jan 5, 2021
@naz
Copy link
Member

naz commented Jan 5, 2021

Thanks @sainthkh, greatly appreciate your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants