Added new settings for members signup redirects #12370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#12366 Two new settings for redirecting members after signup, based on if they're paid or free, defaulting to the current redirect of "/"
8 tasks
rishabhgrg
approved these changes
Nov 17, 2020
tpatel
approved these changes
Nov 17, 2020
daniellockyer
approved these changes
Nov 17, 2020
|
@tpatel So this migration is to ensure that the setting is added to the right group when migrating from v. old version, there is no previous value in this case so a The signature for the helper we're using doesn't have default params so we have to pass it explicitly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #12366
Two new settings for redirecting members after signup, based on if
they're paid or free, defaulting to the current redirect of "/"