fix ghost.initPlugins: the activePlugins setting wasn't read correctly. #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix comment: activePlugins is read from settings, not from config.
- model.Settings.activePlugins: this doesn't work and is replaced by model.Settings.read('activePlugins').
- because Settings.read returns a promise, the last line is wrapped with "when(...).then(...)".
The commit is necessary to get plugins working. To test this you can manually change the activePlugins setting in the settings database.
|
I already have most of this covered in #931. Except the comment change I think. I would favor my approach, but I'm sure anyone would say that about their own code. |
|
Thanks for the heads-up. I will see if #931 works for me and than I can close this PR. |
|
@frysbe: There is a lot of ongoing discussion around the Plugin API, I encourage you to join in - but if you're trying to build plugins for Ghost be warned the API is not finalised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit is necessary to get plugins working. To test this you can manually change the activePlugins setting in the settings database.