Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a warning message if js is not built #1301

Merged
merged 1 commit into from
Oct 28, 2013
Merged

Adding a warning message if js is not built #1301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/client/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
};

Ghost.init = function () {
// remove the temporary message which appears
$('.js-msg').remove();

Ghost.router = new Ghost.Router();

// This is needed so Backbone recognizes elements already rendered server side
Expand Down
4 changes: 4 additions & 0 deletions core/server/views/default.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@

{{{body}}}

<div class="js-msg">
<p>Hello There! Looks like something went wrong with your JavaScript.</p>
<p>Either you need to enable JavaScript, or you haven't built the JavaScript files yet. See the README and CONTRIBUTING files for more info.</p>
</div>
</main>

<div id="modal-container">
Expand Down