馃悰 Added the member context to the get, next-post and prev-post helpers #14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14256 +/- ##
==========================================
+ Coverage 55.43% 55.44% +0.01%
==========================================
Files 564 564
Lines 46725 46736 +11
Branches 3980 3980
==========================================
+ Hits 25900 25915 +15
+ Misses 20785 20781 -4
Partials 40 40
Continue to review full report at Codecov.
|
matthanley
reviewed
Mar 2, 2022
matthanley
approved these changes
Mar 2, 2022
|
When this is squashed + merged, it would be great to update the commit title to communicate the problem that's fixed (access is incorrect when using get helper) rather than the fix itself so it makes sense to users who don't have context |
SimonBackx
force-pushed
the
fix/get-helper-member-context
branch
from
66f3d8d
to
6b91e63
Compare
refs https://github.com/TryGhost/Team/issues/1367 - The {{access}}聽property of a post always returned false for non-public content - The get, next-post and prev-post helpers didn't add the member context to the internal API calls - Added the members context to these calls - Added tests that check if the member context is passed to the API calls
SimonBackx
force-pushed
the
fix/get-helper-member-context
branch
from
6b91e63
to
7e00dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Team/issues/1367
Tests:
const should = require('should');to the next-post and prev-post helper tests to allow them to run on their own