馃彈 Dropped webhooks.status column
#14713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #14713 +/- ##
==========================================
- Coverage 61.15% 61.14% -0.02%
==========================================
Files 572 572
Lines 46841 46839 -2
Branches 4207 4208 +1
==========================================
- Hits 28646 28640 -6
- Misses 18151 18155 +4
Partials 44 44
Continue to review full report at Codecov.
|
daniellockyer
force-pushed
the
webhooks-status
branch
from
79b4e20
to
aa8898e
Compare
matthanley
reviewed
May 9, 2022
daniellockyer
force-pushed
the
webhooks-status
branch
from
aa8898e
to
528795c
Compare
daniellockyer
changed the title
webhooks.status columnwebhooks.status column
|
@matthanley + @SimonBackx: note that I've changed the migration to dropping the |
refs TryGhost/Toolbox#309 - this column is not used and I was going to add `validation` to it but it's better to clean it up and re-add the column if we need it again
daniellockyer
force-pushed
the
webhooks-status
branch
from
528795c
to
a72bf30
Compare
SimonBackx
approved these changes
May 11, 2022
matthanley
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://github.com/TryGhost/Toolbox/issues/309
validationto it butit's better to clean it up and re-add the column if we need it again