Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fixed email alerts for paid members on import #15347

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

rishabhgrg
Copy link
Contributor

closes https://github.com/TryGhost/Team/issues/1868

  • email alerts should not be sent out when paid subscriptions are created via our importer

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #15347 (85ec654) into v5.12.3 (c9f782a) will increase coverage by 6.00%.
The diff coverage is 37.50%.

@@             Coverage Diff             @@
##           v5.12.3   #15347      +/-   ##
===========================================
+ Coverage    52.75%   58.76%   +6.00%     
===========================================
  Files         1399      767     -632     
  Lines        89943    64095   -25848     
  Branches     10220     5683    -4537     
===========================================
- Hits         47451    37663    -9788     
+ Misses       42441    26382   -16059     
+ Partials        51       50       -1     
Impacted Files Coverage 螖
ghost/members-api/lib/repositories/member.js 23.44% <37.50%> (+10.44%) 猬嗭笍
...enig-editor/addon/components/koenig-card-button.js
ghost/admin/app/components/gh-notification.js
ghost/admin/app/components/gh-benefit-item.js
ghost/admin/app/services/members-stats.js
ghost/admin/app/controllers/settings/tiers.js
ghost/admin/app/adapters/setting.js
ghost/admin/app/helpers/ui-text.js
.../app/components/dashboard/resources/staff-picks.js
ghost/admin/app/validators/setup.js
... and 624 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rishabhgrg rishabhgrg force-pushed the fix-email-alert-import branch 2 times, most recently from cdf09ff to 419cc19 Compare September 1, 2022 14:18
@rishabhgrg rishabhgrg changed the base branch from main to v5.12.3 September 1, 2022 14:19
closes https://github.com/TryGhost/Team/issues/1868

- email alerts should not be sent out when paid subscriptions are created via our importer
@rishabhgrg rishabhgrg merged commit c4041e4 into TryGhost:v5.12.3 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant